Open
Conversation
antonio06
reviewed
Apr 15, 2026
| averageOneYearAgo={dataOneYearAgo.average} | ||
| monthTenYearsAgo={dataTenYearsAgo.month} | ||
| yearTenYearsAgo={dataTenYearsAgo.year} | ||
| averageTenYearsAgo={dataTenYearsAgo.average} |
Member
There was a problem hiding this comment.
I think the best option is to pass dataTenYearsAgo and dataOneYearAgo instead of splitting each property individually
| averageOneYearAgo: number; | ||
| monthTenYearsAgo: number; | ||
| yearTenYearsAgo: number; | ||
| averageTenYearsAgo: number; |
Member
There was a problem hiding this comment.
pass dataTenYearsAgo dataOneYearAgo instead
| dataOneYearAgo={{ | ||
| average: dataOneYearAgo.average, | ||
| month: dataOneYearAgo.month, | ||
| year: dataOneYearAgo.year, |
Member
There was a problem hiding this comment.
we can change this to dataOneYearAgo={dataOneYearAgo}
| <HistoryChart | ||
| reservoirName={reservoirData.nombre} | ||
| currentLevel={reservoirData.currentVolume} | ||
| maxCapacity={reservoirData.totalCapacity} |
Member
There was a problem hiding this comment.
we can change this properties to reservoirData={reservoirData}
| const expectResult = { | ||
| month: 3, | ||
| average: 54, | ||
| year: new Date().getFullYear() - 1, |
Member
There was a problem hiding this comment.
@manudous its posible mock this, or its not worth it ?
| generatedAt: metadata.generatedAt, | ||
| periodoInicio: metadata.periodoInicio, | ||
| periodoFin: metadata.periodoFin, | ||
| }, |
Member
There was a problem hiding this comment.
i think this option its more clear
meses: monthly.map((month) => (month)),
metadata: metadata,
| generatedAt: metadata.generatedAt, | ||
| periodoInicio: metadata.periodoInicio, | ||
| periodoFin: metadata.periodoFin, | ||
| }, |
Member
There was a problem hiding this comment.
meses: monthly.map((month) => (month)),
metadata: metadata,
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closed #199