Skip to content

feature/#245 review the template in markdown and check all the fields #313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MiguelJiRo wants to merge 4 commits into
base: feature/develop
Choose a base branch
from
Open

feature/#245 review the template in markdown and check all the fields #313

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0867e1e
Added some checks to the markdown template fields
MiguelJiRo Dec 16, 2023
dbbcf88
Sections updated and fixed with the comments from the pull request
MiguelJiRo Jan 7, 2024
422e86a
condition in the studies section removed
MiguelJiRo Jan 8, 2024
101140e
Update experience-section.ejs
juanpms2 Jan 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion packages/manfred2md/src/engine/md-parts/experience-section/experience-section.ejs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,18 +4,32 @@
<%_ if (experienceCollection && experienceCollection !== 'undefined') { -%>
<%_ for (const job of experienceCollection) { -%>
- #### <%- job.name %>
<%_ if (job.type && job.type !== 'undefined' ) { -%>
- **Tipo de Organización:** <%- job.type %>
<%_ } -%>
<%_ if (job.description && job.description !== 'undefined' ) { -%>
- **Descripción:** <%- job.description %>
<%_ } -%>
- **Roles dentro de la empresa:**
Comment thread
juanpms2 marked this conversation as resolved.
Outdated
<%_ if (job.roles && job.roles !== 'undefined' ) { -%>
<%_ for (const role of job.roles) { -%>
<%_ if (role.name && role.name !== 'undefined' ) { -%>
- **<%= role.name %>**
<%_ } -%>
<%_ if (role.startDate && role.startDate !== 'undefined' && role.finishDate !== 'undefined' ) { -%>
Comment thread
juanpms2 marked this conversation as resolved.
Outdated
- **Duración:** <%= role.startDate %> - <%= role.finishDate ?? 'Actualidad' %>
- **Retos:**
<%_ } else if ((!role.startDate || role.startDate === 'undefined') && role.finishDate && role.finishDate !== 'undefined' ) { -%>
- **Duración:** Finalizado en <%= role.finishDate %>
<%_ } else if ((!role.startDate || role.startDate === 'undefined') && role.finishDate !== 'undefined') { -%>
- **Duración:** <%= role.finishDate ?? 'Actualidad' %>
<%_ } -%>
<%_ if (role.challenges && role.challenges !== 'undefined' ) { -%>
- **Retos:**
<%_ for (const challenge of role.challenges) { -%>
<%_ if (challenge.description && challenge.description !== 'undefined') { -%>
- <%= challenge.description %>
<%_ } -%>
<%_ } -%>
<%_ } -%>
<%_ } -%>
<%_ } -%>
Expand Down
4 changes: 2 additions & 2 deletions packages/manfred2md/src/engine/md-parts/studies-section/studies-section.ejs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,12 +21,12 @@
- **Fecha de inicio y finalización:** <%= study.startDate %> - <%= study.finishDate === "" ? "Actualidad" : study.finishDate %>
<%_ } -%>

<%_ if ( study?.institution ) { -%>
<%_ if ( study?.institution.name ) { -%>
- **Nombre de Institución:** <%= study.institution.name %>
<%_ } -%>

<%_ if ( study.institution.location?.region || study.institution.location?.country ) { -%>
- **Ubicación de la Institución:** <%= study.institution.location.region %>, <%= study.institution.location.country %>
- **Ubicación de la Institución:** <%= study.institution.location.region ? ( study.institution.location?.country ? study.institution.location.region + ", " : study.institution.location.region) : "" %><%= study.institution.location.country %>
<%_ } -%>
<%_ } -%>
<%_ } -%>
Expand Down