Repository navigation
🔗 fix: Update Node Runtimes And Preserve Restored Modules - #347
Conversation
|
Head: bdaca35. Includes canonical target checks so parent-path segments cannot cause external user links to be replaced. All 46 migration regressions pass on Node 24.22.1. Fresh independent review and final focused checks are starting for this head. |
|
Head: 1cf876c. Validation: 146 focused API tests and 46 Node 24.22.1 migration tests pass. API build, formatting, shell syntax, and diff checks pass. API typecheck has seven baseline diagnostics, unchanged in codes/messages from main. Independent review is complete: no remaining findings. P2-1 runtime-link migration fixed in 67f8305; P2-2 canonical user-link preservation fixed in bdaca35; P2-3 cache fixture isolation fixed in 1cf876c. CI has no failures; remaining image builds are visible in the checks. Full API/Service suites and the ARM/KVM build matrix are CI-only; local verification used focused tests. |
|
@codex review the latest head, final review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1cf876c6c6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Head: 304d09e. Both Codex P2 findings are fixed in Validation: 168 focused API/checkpoint/route tests pass; 131 focused tests pass with ESM subprocesses on each patched Node version. Unmodified cached-PVC initialization and Node/Bun ESM checks pass without network or runtime reinstalls. API build, new-test formatting, shell syntax, Dockerfile checks, and diff checks pass. API typecheck retains seven baseline diagnostics, unchanged in codes/messages. CI: 20 passing checks; failures: none; remaining: code-interpreter-sandbox-runner, Lambda MicroVM Runner Image (arm64). Full API/Service suites and the ARM/KVM matrix were left to CI. No live Kubernetes upgrade was run. |
|
@codex review the latest head, final review |
|
Codex Review: Didn't find any major issues. 🎉 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
lia-by-librechat
Bot
changed the title
|
Head: ea984bf. Self-contained runtime update: Node 24.22.1 sandbox/extraction and Node 22.23.4 broker/service images. Installer, Helm, service request selection, and CI pins are aligned. No dependency on closed #346; no contributor commit reused. Independent review of this exact head is complete with no findings. Prior P2 fixes remain: runtime-link migration (67f8305), canonical user-link preservation (bdaca35), cache fixture isolation (1cf876c), cached PVC launcher refresh and workspace-command preparation (304d09e). No findings rejected. Validation: 168 guest-image API/checkpoint/route tests; 131 API and 51 worker tests with each patched Node; 14 extraction and 16 service-config tests pass. Extraction qualification includes 75 adversarial fixtures, isolation, cleanup, and restart. Native addon/IPC smoke, Helm/default override checks, Dockerfile validation, builds, scoped lint/formatting, shell syntax, and diff checks pass. Code/extraction typechecks pass; API/service retain seven unchanged baseline errors each. CI: 21 passing; failures: none; remaining: code-interpreter-sandbox-runner, Lambda MicroVM Runner Image (arm64). Full API/Service suites and ARM/KVM builds were left to CI. Legacy service/Dockerfile.node was statically checked, not fully built. No live Kubernetes upgrade or deployment was run. Codex’s clean review covers 304d09e, not this new head. |
Summary
Update sandbox Node to
24.22.1and broker/service Node to22.23.4, while preserving bundled-module imports across upgrades.Self-contained replacement for closed #346. No contributor commit was reused.
Validation
Head:
ea984bffb4b9a8ef7789ac236d230a9bb625489a.Independent review of this exact head is complete with no findings. All five prior ledger items remain fixed. Codex passed the previous head; that result does not cover this update.