Skip to content

fix: align prepare release template with consumer contract #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vitormattos merged 1 commit into from
Sep 30, 2026
Merged

fix: align prepare release template with consumer contract #82

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions tests/test_release_tool_pins.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,12 @@


class ReleaseToolPinsTest(unittest.TestCase):
def test_prepare_release_keeps_trusted_pipeline_contract(self) -> None:
content = (ROOT / "workflow-templates/prepare-release.yml").read_text(encoding="utf-8")
self.assertIn("pipeline-reference-ref: refs/remotes/origin/main", content)
self.assertIn("post-merge-event: pull_request_target", content)
self.assertIn('git fetch --quiet origin "+refs/heads/main:refs/remotes/origin/main"', content)

def test_release_tool_consumers_use_same_release(self) -> None:
for path in SURFACES:
content = path.read_text(encoding="utf-8")
Expand Down
8 changes: 8 additions & 0 deletions workflow-templates/prepare-release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,12 @@ jobs:
set -euo pipefail
git fetch --quiet --unshallow --prune origin "+refs/heads/${RELEASE_BRANCH}:refs/remotes/origin/${RELEASE_BRANCH}" "+refs/tags/*:refs/tags/*"

- name: Fetch trusted release pipeline reference
shell: bash
run: |
set -euo pipefail
git fetch --quiet origin "+refs/heads/main:refs/remotes/origin/main"

- name: Prepare release
uses: LibreCodeCoop/release-tool/actions/prepare@40e17457fe28003e5893bf55e3c2102c965ddb8c
with:
Expand All @@ -93,6 +99,7 @@ jobs:
actor: ${{ github.actor }}
github-token: ${{ secrets.GITHUB_TOKEN }}
app-private-key: ${{ secrets.LIBRECODE_WORKFLOW_APP_PRIVATE_KEY }}
pipeline-reference-ref: refs/remotes/origin/main

post_merge:
name: Finalize release and prepare draft
Expand Down Expand Up @@ -156,4 +163,5 @@ jobs:
github-release-id: ${{ github.event.release.id }}
config-path: .nextcloud-release.yml
post-merge-workflow-path: .github/workflows/prepare-release.yml
post-merge-event: pull_request_target
github-token: ${{ secrets.GITHUB_TOKEN }}
Loading