Skip to content

[stable34] fix(release): preserve GitHub Actions setup on stable34 - #8843

Merged
vitormattos merged 16 commits into
stable34from
fix/release-makefile-github-actions-stable34
Sep 29, 2026
Merged

vitormattos merged 16 commits into
stable34from
fix/release-makefile-github-actions-stable34

Conversation

@vitormattos

@vitormattos vitormattos commented Sep 29, 2026 •

Copy link
Copy Markdown
Member

Fix the Makefile regression that caused GitHub Actions release packaging to skip Nextcloud setup.

  • use the Make-native $(GITHUB_ACTIONS) variable inside the recipe
  • avoid shell-variable syntax that GNU Make consumes before the shell sees it
  • keep managed and release-validation workflows unchanged

A separate follow-up will define a proper Makefile/build regression strategy instead of coupling build semantics to PHPUnit or a one-off workflow.

Signed-off-by: Vitor Mattos <vitor@php.rio>
Signed-off-by: Vitor Mattos <vitor@php.rio>
@vitormattos
vitormattos requested a review from a team as a code owner September 29, 2026 13:12
@github-actions github-actions Bot changed the title fix(release): preserve GitHub Actions setup on stable34 [stable34] fix(release): preserve GitHub Actions setup on stable34 Sep 29, 2026
@vitormattos vitormattos added this to the Next Patch (34) milestone Sep 29, 2026 — with ChatGPT Codex Connector
Signed-off-by: Vitor Mattos <vitor@php.rio>
Signed-off-by: Vitor Mattos <vitor@php.rio>
Signed-off-by: Vitor Mattos <vitor@php.rio>
Signed-off-by: Vitor Mattos <vitor@php.rio>
Signed-off-by: Vitor Mattos <vitor@php.rio>
Signed-off-by: Vitor Mattos <vitor@php.rio>
Signed-off-by: Vitor Mattos <vitor@php.rio>
Signed-off-by: Vitor Mattos <vitor@php.rio>
Signed-off-by: Vitor Mattos <vitor@php.rio>
Signed-off-by: Vitor Mattos <vitor@php.rio>
Signed-off-by: Vitor Mattos <vitor@php.rio>
Signed-off-by: Vitor Mattos <vitor@php.rio>
Signed-off-by: Vitor Mattos <vitor@php.rio>
Signed-off-by: Vitor Mattos <vitor@php.rio>
@vitormattos
vitormattos merged commit 66427f3 into stable34 Sep 29, 2026
61 checks passed
@vitormattos
vitormattos deleted the fix/release-makefile-github-actions-stable34 branch September 29, 2026 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant