fix(executor): make wait a completion barrier - #148
Merged
Merged
Conversation
Track MPSC submissions before publication and complete each ticket when the task runs or is rejected. Make wait and resize drain against the completion protocol, and add blocked-task, nested-submission, and stress regressions for the documented wait contract.
Use atomic submission and completion counters so the MPSC producer path does not acquire a new mutex. Keep the wait condition variable only for blocking callers while preserving the completion barrier.
Update the completion state while holding the wait mutex before notifying condition-variable waiters. This prevents a lost wake-up while keeping the MPSC submission path free of locks.
Give the TaskExecutor wait regression a bounded CTest timeout so a future completion protocol regression fails the suite instead of hanging CI indefinitely.
Describe TaskExecutor::wait as a moving completion frontier that includes nested submissions before the barrier closes and may be delayed by continuous producers. Record the MPSC completion race fix in the Unreleased changelog.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
This is intentionally separate from the merged gzip/benchmark PR #147.