bench: add contract-matched async benchmark - #150
Merged
Merged
Conversation
Add a separate async payload contract so null-sink comparisons carry the same message through LogIt++ and spdlog queues. Version benchmark metadata, isolate matched CSV output, and document the workload distinction in the benchmark guides and CI smoke.
Add a functional regression test for the full-message async null-sink contract and expose a benchmark-only sink observer for exact payload verification. Run the test in the benchmark CI job alongside the existing validation smoke.
Include workload_contract in the latency CSV schema and reject pre-contract result files. Keep the contract visible in every exported row so benchmark results remain auditable outside the console metadata receipt.
Clarify that the matched benchmark aligns queued payload ownership while the surrounding LogIt++ and spdlog work remains implementation-specific.
Make the contract-matched benchmark structurally emit only async null scenarios while preserving the full matrix for the historical benchmark. Update the usage documentation to reflect the enforced workload boundary.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
async=1andsink=null.workload_contractin runtime metadata and every CSV row.Verification
benchmark_validation_test,logit_bench_async_payload_contract_test,logit_bench_flush_test).main(1ca7ea2).