Skip to content

Commit 26c1f24

Browse files
committed
fixes, eliminating redundant build-dep 'gettext'
1 parent ec53465 commit 26c1f24

2 files changed

Lines changed: 28 additions & 20 deletions

File tree

debian/configure

Lines changed: 28 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ Usage:
2222
2323
Extra options:
2424
25-
no-docs|nodocs|nodoc
25+
no-docs|nodocs|nodoc|no-doc
2626
Skip building documentation.
2727
Debian packaging will not know about documentation to exist at all.
2828
If configured regularly but with the intent not to build the docs,
@@ -32,7 +32,7 @@ Usage:
3232
Accepted for compatibility, but now ignored.
3333
3434
-h|--help|help
35-
Show this help.
35+
Show this help.
3636
EOF
3737
}
3838

@@ -58,10 +58,10 @@ while test $# -ne 0; do
5858
case "$1" in
5959
sim|uspace|noauto) echo "I: Argument $1 is accepted for compatibility, but ignored";;
6060
help|-h|--help) usage; exit 0 ;;
61-
no-docs|nodocs|nodoc) unset ENABLE_BUILD_DOCUMENTATION ;;
61+
no-docs|nodocs|nodoc|no-doc) unset ENABLE_BUILD_DOCUMENTATION ;;
6262
*) echo 1>&2 "Unknown option: $1"
6363
echo 1>&2
64-
usage
64+
usage
6565
exit 99 ;;
6666
esac
6767
shift
@@ -88,14 +88,14 @@ if [ -n "$ENABLE_BUILD_DOCUMENTATION" ]; then
8888

8989

9090
case $DISTRIB_NAME in
91-
Debian-9)
92-
;; # No xetex in Debian 9 Stretch
93-
*)
94-
# Not quite sure which packages is needed for xetex, but
95-
# texlive-xetex seem like a safe choice. Need xetex to be
96-
# able to build Chinese PDF.
97-
DOC_DEPENDS="$DOC_DEPENDS,\n texlive-xetex"
98-
;;
91+
Debian-9)
92+
;; # No xetex in Debian 9 Stretch
93+
*)
94+
# Not quite sure which packages is needed for xetex, but
95+
# texlive-xetex seem like a safe choice. Need xetex to be
96+
# able to build Chinese PDF.
97+
DOC_DEPENDS="$DOC_DEPENDS,\n texlive-xetex"
98+
;;
9999
esac
100100
else
101101
DOC_DEPENDS=''
@@ -224,21 +224,28 @@ echo " The DEB_BUILD_OPTIONS environment variable also works with dpkg-buildpa
224224

225225
if command -v dpkg-checkbuilddeps > /dev/null; then
226226

227+
a=""
227228
if [ -n "$ENABLE_BUILD_DOCUMENTATION" ]; then
228-
a=$(cd .. && dpkg-checkbuilddeps || true)
229+
a=$(cd .. && dpkg-checkbuilddeps 2>&1 || true)
229230
if [ -n "$a" ]; then
230-
echo "W: To successfully build all of LinuxCNC, install the following build dependencies are mising:\n$a"
231-
echo " The missing packages are auto-installed by"
232-
echo " sudo apt build-dep ."
231+
echo "W: To successfully build all of LinuxCNC, install the following build dependencies are mising:"
233232
else
234-
echo "I: No build dependencies missing for complete builds including documentation."
233+
echo "I: All build dependencies available for complete builds including the documentation."
235234
fi
236235
else
237-
a=$(cd .. && dpkg-checkbuilddeps -B || true)
236+
a=$(cd .. && dpkg-checkbuilddeps -B 2>&1 || true)
238237
if [ -n "$a" ]; then
239-
echo "I: No dependencies missing for building binaries only."
238+
echo "W: To successfully build the architecture-dependent parts of LinuxCNC, the following build dependencies are mising:"
239+
else
240+
echo "I: No dependencies missing while not building the documentation."
240241
fi
241242
fi
243+
if [ -n "$a" ]; then
244+
# The common part once missing packages have been identified
245+
echo -n " "; echo "$a" | cut -f4 -d:
246+
echo " The missing packages are auto-installed by"
247+
echo " sudo apt build-dep ."
248+
fi
242249
else
243250
echo "W: Tool to check build-dependenices not found"
244251
echo " You may want to install it as follows:"
@@ -248,3 +255,5 @@ else
248255
echo " or just execute"
249256
echo " sudo apt build-dep ."
250257
fi
258+
259+
# vim: ts=4

debian/control.top.in

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,6 @@ Build-Depends:
2222
automake,
2323
bwidget (>= 1.7),
2424
desktop-file-utils,
25-
gettext,
2625
intltool,
2726
libboost-python-dev,
2827
libepoxy-dev,

0 commit comments

Comments
 (0)