test(tray): add system tray tests - #4221
Conversation
5ecfd6d to
e2dbaec
Compare
Bundle ReportBundle size has no change ✅ |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4221 +/- ##
==========================================
+ Coverage 26.07% 28.00% +1.93%
==========================================
Files 109 109
Lines 24528 24683 +155
Branches 10753 10887 +134
==========================================
+ Hits 6395 6912 +517
+ Misses 16877 15921 -956
- Partials 1256 1850 +594
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 65 files with indirect coverage changes Continue to review full report in Codecov by Harness.
|
e2dbaec to
3121286
Compare
|
3121286 to
d053212
Compare
|
It looks like this PR has been idle for 90 days. If it's still something you're working on or would like to pursue, please leave a comment or update your branch. Otherwise, we'll be closing this PR in 10 days to reduce our backlog. Thanks! |
ac349a0 to
ebb1a16
Compare
ebb1a16 to
d422be5
Compare
Moves the primary tray icon into common packaging so `logo-sunshine.svg` is always copied into built web assets, and removes the Linux-specific duplicate install step. System tray icon path macros are consolidated to use shared SVG defaults, and tray tests now stage required icon assets in the test build directory and assert all icon files exist before running visual tray initialization.
|
2 participants
Description
This PR intends to add tests for the system tray, and depends on #3818
It was originally to be included with 3818, but there are issues with the tests that need to be resolved in the different build environments and it was growing out of hand.
At the time of opening the PR, the tests succeed on Windows, but fail on Linux. Unknown status on macOS due to homebrew builds failing right now.
Screenshot
Issues Fixed or Closed
Roadmap Issues
Type of Change
Checklist
AI Usage