Skip to content

fix(linux): route Xbox Series gamepad through uinput#54

Open
ReenigneArcher wants to merge 4 commits into
masterfrom
fix/linux/gamepad-mappings
Open

fix(linux): route Xbox Series gamepad through uinput#54
ReenigneArcher wants to merge 4 commits into
masterfrom
fix/linux/gamepad-mappings

Conversation

@ReenigneArcher

@ReenigneArcher ReenigneArcher commented Jul 14, 2026

Copy link
Copy Markdown
Member

Description

Adds a dedicated Linux uinput Xbox Series backend that emits canonical evdev button/axis events and translates force-feedback effects back into normalized rumble callbacks, while keeping other gamepads on UHID. The backend gamepad submit interface now accepts both normalized state and packed report so native backends can consume state directly. It also updates gamepad descriptors/report packing (including misc1 button handling and hat-based dpad bits), sets Switch Pro UHID bus to virtual, refreshes platform/usage docs, and expands Linux adapter/backend/consumer tests accordingly.

Screenshot

Issues Fixed or Closed

Roadmap Issues

Type of Change

  • feat: New feature (non-breaking change which adds functionality)
  • fix: Bug fix (non-breaking change which fixes an issue)
  • docs: Documentation only changes
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semicolons, etc.)
  • refactor: Code change that neither fixes a bug nor adds a feature
  • perf: Code change that improves performance
  • test: Adding missing tests or correcting existing tests
  • build: Changes that affect the build system or external dependencies
  • ci: Changes to CI configuration files and scripts
  • chore: Other changes that don't modify src or test files
  • revert: Reverts a previous commit
  • BREAKING CHANGE: Introduces a breaking change (can be combined with any type above)

Checklist

  • Code follows the style guidelines of this project
  • Code has been self-reviewed
  • Code has been commented, particularly in hard-to-understand areas
  • Code docstring/documentation-blocks for new or existing methods/components have been added or updated
  • Unit tests have been added or updated for any new or modified functionality

AI Usage

See our AI usage policy.

  • None: No AI tools were used in creating this PR
  • Light: AI provided minor assistance (formatting, simple suggestions)
  • Moderate: AI helped with code generation or debugging specific parts
  • Heavy: AI generated most or all of the code changes

@codecov

codecov Bot commented Jul 14, 2026

Copy link
Copy Markdown

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
102 1 101 2
View the top 1 failed test(s) by shortest run time
LinuxConsumerTest::SdlSeesXbox360CanonicalButtons
Stack Traces | 3.22s run time
.../tests/unit/test_linux_consumers.cpp:474
Value of: wait_for_sdl_controller_button(controller.get(), sdl_button)
  Actual: false
Expected: true
logical button 2 controller_type=1 controller_button[0]=0 controller_button[1]=0 controller_button[2]=0 controller_button[3]=1 controller_button[4]=0 controller_button[5]=0 controller_button[6]=0 controller_button[7]=0 controller_button[8]=0 controller_button[9]=0 controller_button[10]=0 controller_button[11]=0 controller_button[12]=0 controller_button[13]=0 controller_button[14]=0 controller_button[15]=0 controller_button[16]=0 controller_button[17]=0 controller_button[18]=0 controller_button[19]=0 controller_button[20]=0 controller_axis[0]=0 controller_axis[1]=0 controller_axis[2]=0 controller_axis[3]=0 controller_axis[4]=0 controller_axis[5]=0 buttons=15 axes=6 button[0]=0 button[1]=0 button[2]=0 button[3]=1 button[4]=0 button[5]=0 button[6]=0 button[7]=0 button[8]=0 button[9]=0 button[10]=0 button[11]=0 button[12]=0 button[13]=0 button[14]=0 axis[0]=0 axis[1]=0 axis[2]=-32768 axis[3]=0 axis[4]=0 axis[5]=-32768

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@ReenigneArcher ReenigneArcher force-pushed the fix/linux/gamepad-mappings branch from b799c70 to cb4c5f9 Compare July 14, 2026 23:03
@ReenigneArcher ReenigneArcher changed the title fix(linux): refine gamepad HID mappings and Linux bus fix(linux): route Xbox Series gamepad through uinput Jul 14, 2026
@ReenigneArcher ReenigneArcher force-pushed the fix/linux/gamepad-mappings branch 2 times, most recently from 61eb72a to 01dec7e Compare July 14, 2026 23:44
Adds a dedicated Linux uinput Xbox Series backend that emits canonical evdev button/axis events and translates force-feedback effects back into normalized rumble callbacks, while keeping other gamepads on UHID. The backend gamepad submit interface now accepts both normalized state and packed report so native backends can consume state directly. It also updates gamepad descriptors/report packing (including misc1 button handling and hat-based dpad bits), sets Switch Pro UHID bus to virtual, refreshes platform/usage docs, and expands Linux adapter/backend/consumer tests accordingly.
@ReenigneArcher ReenigneArcher force-pushed the fix/linux/gamepad-mappings branch from 01dec7e to b44a75e Compare July 15, 2026 02:07
Match the active evdev capabilities exposed by the USB xpad driver instead of the full 15-slot HID layout. Remove unused BTN_C, BTN_Z, BTN_TL2, and BTN_TR2 capabilities that shifted Guide, L3, and R3 indices. Set firmware version to 0x050D for a known SDL/Steam USB mapping. Add Guide button to consumer test coverage.
Update the Linux uinput backend to advertise Xbox Series controllers as Bluetooth with product ID 0x0B13, while keeping the public profile identity unchanged. The evdev key capabilities now include the full 15-slot HID button range (including reserved C/Z/TL2/TR2 slots) so SDL/Steam button indices stay stable and Guide/L3/R3 map correctly. Unit and consumer tests were updated accordingly, and platform support docs now describe the identity split and reserved-slot behavior.
Generalizes the Linux uinput gamepad backend from Xbox Series-only to support Generic, Xbox 360, Xbox One, and Xbox Series profiles. Extracts `uses_uinput_gamepad_profile()` predicate, renames `UinputXboxGamepad` to `UinputGamepad`, makes rumble and misc1 (Share) button conditional on profile capabilities, and updates tests and docs accordingly.
@ReenigneArcher ReenigneArcher force-pushed the fix/linux/gamepad-mappings branch from d3345d5 to 4c55b6b Compare July 15, 2026 21:06
@sonarqubecloud

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
2 New issues
2 New Code Smells (required ≤ 0)

See analysis details on SonarQube Cloud

💡 Need a hand with PR review? Try Gitar by Sonar!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant