fix: make install instructions platform-agnostic - #485
Open
BlockException wants to merge 1 commit into
Open
Conversation
✅ Deploy Preview for luckperms ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Closes #449
Step 3 of the "How to install" section on the Download page hardcodes
/plugins/LuckPerms/as the config file location, which only applies toBukkit/BungeeCord/Velocity/NukkitX. Sponge, Fabric, Forge and NeoForge
use
/config/luckperms/instead, which wasn't mentioned anywhere inthe instructions.
Fix
Updated the
download.install.configstring insrc/messages/en.jsonto mention both possible locations depending on platform, instead of
implying there's only one.
Testing
Ran
npm run serveand checked the/downloadpage — the updatedinstructions render correctly under "How to install".