Skip to content

ci(release): pass tag message via env to prevent shell injection (fix empty v2.6.0-testnet) #303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mateeullahmalik merged 1 commit into from
Jul 2, 2026
Merged

ci(release): pass tag message via env to prevent shell injection (fix empty v2.6.0-testnet) #303

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions .github/workflows/build&release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,13 +74,19 @@ jobs:

- name: Check deploy intent
id: deploy_check
env:
TAG_MSG: ${{ steps.tag_info.outputs.tag_message }}
run: |
TAG_MSG="${{ steps.tag_info.outputs.tag_message }}"
if echo "$TAG_MSG" | grep -qi '\[no-deploy\]'; then
echo "draft=true" >> $GITHUB_OUTPUT
# NOTE: TAG_MSG is passed via env: (not ${{ }} inlined into the script)
# because the tag/commit message is multi-line and may contain shell
# metacharacters or command names (e.g. "deadcode"). Inlining it would
# let those lines execute as bash and abort the release job with exit
# 127. See build&release.yml history / v2.6.0-testnet post-mortem.
if printf '%s' "$TAG_MSG" | grep -qi '\[no-deploy\]'; then
echo "draft=true" >> "$GITHUB_OUTPUT"
echo "⚠️ [no-deploy] detected — release will be created as DRAFT"
else
echo "draft=false" >> $GITHUB_OUTPUT
echo "draft=false" >> "$GITHUB_OUTPUT"
fi

- name: Setup Go and dependencies
Expand Down
Loading