Skip to content

ci(release): remove empty ${{ }} expression from bash comment #310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mateeullahmalik merged 1 commit into from
Jul 6, 2026
Merged

ci(release): remove empty ${{ }} expression from bash comment #310

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions .github/workflows/build&release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,9 +78,10 @@ jobs:
# failure (0 jobs, run_attempt=1 completed instantly). Doing the
# check inline keeps the raw message inside a bash variable and
# only exports the single-line `draft` boolean to downstream steps.
# Prior implementation inlined the message via ${{ }} interpolation,
# which let commit-body tokens (e.g. "deadcode") execute as bash
# and killed v2.6.0-testnet with exit 127. See PR history.
# Prior implementation inlined the message via GitHub Actions
# expression interpolation, which let commit-body tokens (e.g.
# "deadcode") execute as bash and killed v2.6.0-testnet with
# exit 127. See PR history (#303 / #307).
if printf '%s' "$TAG_MESSAGE" | grep -qi '\[no-deploy\]'; then
echo "draft=true" >> "$GITHUB_OUTPUT"
echo "⚠️ [no-deploy] detected — release will be created as DRAFT"
Expand Down
Loading