Skip to content

ci: deploy Workers through GitHub environments - #13

Merged
colinmcdonald22 merged 1 commit into
devfrom
codex/workers-github-actions
Sep 11, 2026
Merged

colinmcdonald22 merged 1 commit into
devfrom
codex/workers-github-actions

Conversation

@colinmcdonald22

Copy link
Copy Markdown
Member

Description

Deploy the Lunar Client SkyCrypt fork through GitHub Actions using the same environment-based account selection as Web and multiver-bsdiff-generator. The fork's existing workflows only publish Docker images for the upstream repository, so they do not deploy this fork to Workers.

dev selects cloudflare-production and deploys skycrypt-embed.lunarclient.com. Other branches select cloudflare-development and upload branch-aliased previews after initializing the development Worker when needed. Existing lint, type, and test checks gate both paths.

Type of Change

  • Build/CI changes
  • Updating existing tests

Changes Made

  • Read CLOUDFLARE_ACCOUNT_ID and CLOUDFLARE_API_TOKEN from GitHub environment secrets and select Wrangler configuration with vars.CLOUDFLARE_ENV.
  • Define production/development Wrangler environments with the same skycrypt-embed Worker name, preserve the existing API URLs, and remove the shared-account observability Tail Worker binding.
  • Disable resource auto-provisioning and declare the already-locked Wrangler 4.127.1 as a direct development dependency for CI.
  • Correct six stale preference-test expectations to match the fork's existing defaults: performance mode enabled and glint disabled. Runtime behavior is unchanged.
  • Document environment setup and local validation.

Testing

  • actionlint and git diff --check
  • pnpm lint, including Svelte/TypeScript checks
  • pnpm build
  • Wrangler bundle dry-runs for development and production
  • Existing test suite: 444 passed, 14 skipped

Validated locally on macOS with Node 24.21.0, pnpm 11.11.0, and Playwright Chromium.

Deployment Notes

The GitHub deployment environments are not yet configured. Each needs the account/token secrets and CLOUDFLARE_ENV variable; restrict cloudflare-production to the dev branch. The production account must contain the lunarclient.com zone. Coordinate the old Workers Builds integration cutover before enabling deployments so both systems do not deploy concurrently.

No Cloudflare resources or GitHub credentials were provisioned as part of this change. The branch workflow runs normally and requires the development environment to be configured before its deployment step can succeed.

@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Updated (UTC)
❌ Deployment failed
View logs
skycrypt-embed-lunarclient-com 48ec864 Sep 11 2026, 09:15 PM

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 11, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
🔒 Security Review ✅ Completed 2026-09-11T21:24:22.641319Z 48ec864 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@colinmcdonald22
colinmcdonald22 merged commit 8ff8e84 into dev Sep 11, 2026
15 of 17 checks passed
@colinmcdonald22
colinmcdonald22 deleted the codex/workers-github-actions branch September 11, 2026 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant