ci: deploy Workers through GitHub environments - #13
Merged
Merged
Conversation
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ❌ Deployment failed View logs |
skycrypt-embed-lunarclient-com | 48ec864 | Sep 11 2026, 09:15 PM |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Deploy the Lunar Client SkyCrypt fork through GitHub Actions using the same environment-based account selection as Web and multiver-bsdiff-generator. The fork's existing workflows only publish Docker images for the upstream repository, so they do not deploy this fork to Workers.
devselectscloudflare-productionand deploysskycrypt-embed.lunarclient.com. Other branches selectcloudflare-developmentand upload branch-aliased previews after initializing the development Worker when needed. Existing lint, type, and test checks gate both paths.Type of Change
Changes Made
CLOUDFLARE_ACCOUNT_IDandCLOUDFLARE_API_TOKENfrom GitHub environment secrets and select Wrangler configuration withvars.CLOUDFLARE_ENV.skycrypt-embedWorker name, preserve the existing API URLs, and remove the shared-account observability Tail Worker binding.Testing
actionlintandgit diff --checkpnpm lint, including Svelte/TypeScript checkspnpm buildValidated locally on macOS with Node 24.21.0, pnpm 11.11.0, and Playwright Chromium.
Deployment Notes
The GitHub deployment environments are not yet configured. Each needs the account/token secrets and
CLOUDFLARE_ENVvariable; restrictcloudflare-productionto thedevbranch. The production account must contain thelunarclient.comzone. Coordinate the old Workers Builds integration cutover before enabling deployments so both systems do not deploy concurrently.No Cloudflare resources or GitHub credentials were provisioned as part of this change. The branch workflow runs normally and requires the development environment to be configured before its deployment step can succeed.