Skip to content

fix: prefer plain SERVER_API_TOKEN over the Secrets Store binding at build time #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
colinmcdonald22 merged 1 commit into from
Sep 13, 2026
Merged

fix: prefer plain SERVER_API_TOKEN over the Secrets Store binding at build time #17

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions src/lib/shared/api/mutator/custom-instance.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,9 +36,12 @@ const tryGetRequestEvent = () => {
export const customFetch = async <T>(url: string, options: RequestInit): Promise<T> => {
const event = tryGetRequestEvent();

// Deployed Workers get a Secrets Store binding; local dev and prerender get a plain string
const token = event?.platform?.env.SERVER_API_TOKEN ?? envPrivate.SERVER_API_TOKEN;
const serverApiToken = typeof token === "string" ? token : await token.get();
// Deployed Workers get a Secrets Store binding (also surfaced through $env/dynamic/private);
// local dev and prerender get a plain string. Prefer the dynamic env: during `vite build` the
// platform proxy exposes a binding whose get() fails because the secret only exists remotely.
const token =
(envPrivate.SERVER_API_TOKEN as App.Platform["env"]["SERVER_API_TOKEN"]) ?? event?.platform?.env.SERVER_API_TOKEN;
const serverApiToken = typeof token === "string" ? token : ((await token?.get()) ?? "");

const requestInit: RequestInit = {
...options,
Expand Down
Loading