Repository navigation
Bundle private Adventure NBT for legacy disc reads - #2
Merged
ParadauxIO merged 1 commit intoOct 25, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
The Paper 26.3 modernization branch reads historical disc tags using Adventure NBT, but declares it
compileOnly. When a disc has no modern PDC value and the server does not expose Adventure NBT, the fallback fails with:The existing tests supply NBT directly, which hides this packaging failure. This targets
feature/paper-26.3-modernizationbecause the originalmasterimplementation does not use this reader; it is a focused follow-up to #1.How?
Bundle Adventure NBT and relocate it under MusicBox's private package. The reader logic and persisted item format remain unchanged.
Add a packaged-JAR regression test whose classloader refuses external
net.kyori.adventure.nbtclasses and loads the handler from the actual shaded artifact. It checks modern PDC precedence, migrated custom data, legacy tags, absent/malformed data, and writes that preserve the original item. The test fails with the original packaging (NoClassDefFoundError) and passes with this fix.Validation:
./gradlew :plugin:test buildon Java 25 passes all 24 tests. Equivalent packaged code also passed modern and legacy item reads on a running Paper 26.3 server. Audible playback was not exercised.Diagram
Not applicable: this changes dependency packaging, with no change to the disc-reading flow.
Screenshots
Not applicable: dependency packaging and item-data regression tests have no visual output.