Skip to content

Edge case for datafiles with odd number of bins - #459

Merged
simmsa merged 2 commits into
MHKiT-Software:developfrom
jmcvey3:nortek
Aug 6, 2026
Merged

Edge case for datafiles with odd number of bins#459
simmsa merged 2 commits into
MHKiT-Software:developfrom
jmcvey3:nortek

Conversation

@jmcvey3

@jmcvey3 jmcvey3 commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Quick fix for classic Nortek profiling instruments.

Sometimes but not always, an extra fill byte is included at the end of profiles with odd numbers of bins.

Solution for Issue #458

@jmcvey3

jmcvey3 commented Aug 5, 2026

Copy link
Copy Markdown
Contributor Author

@simmsa @akeeste Can we add this as a hotfix for the latest release? Might need to go directly into main instead of develop

@simmsa

simmsa commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

@jmcvey3 Yes, I think that seems reasonable to merge directly into main.

I will handle the merge and will merge main back into develop. Looks like I forgot to merge back #457 so I will use that to get develop in sync in main after merging.

@simmsa
simmsa merged commit c48586f into MHKiT-Software:develop Aug 6, 2026
@simmsa simmsa mentioned this pull request Aug 6, 2026
@simmsa

simmsa commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

@jmcvey3, pushed. This made more sense to go develop -> main.

At this time, v1.1.1 has not been pushed to pypi as actions are down, https://www.githubstatus.com/, and we use them to push to pypi. Hopefully this gets fixed and happens automatically but I will revisit incase we need to figure out an alternative solution.

@simmsa

simmsa commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

@jmcvey3, the action issues were resolved and 1.1.1 is live: https://pypi.org/project/mhkit/1.1.1/

@jmcvey3
jmcvey3 deleted the nortek branch August 7, 2026 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants