Fix height FULL OUTER JOIN coalescing h1 instead of h2#2013
Open
Chessing234 wants to merge 1 commit into
Open
Conversation
Inch-only height rows from ht_in had NULL subject_id/stay_id/charttime because COALESCE used h1 for both arguments. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In
ht_stg0,COALESCE(h1.subject_id, h1.subject_id)(and stay_id/charttime) usedh1for both arguments after the FULL OUTER JOIN of cm and inch heights. Inch-only rows fromht_inhad NULL keys and were dropped downstream.Fix
Use
h2as the fallback for subject_id, stay_id, and charttime in all three dialect copies ofheight.sql.Fixes #2010
Made with Cursor