Repository navigation
fix(castle-siege): don't punish kills between opposing siege sides - #1348
Merged
Merged
Conversation
During the battle, the attacks and kills between players of different Castle Siege sides are exempted from the player killer penalty and the self-defense, unless their guilds were declared rivals. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011xNc764bgrPZRQYCRzPj1x
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011xNc764bgrPZRQYCRzPj1x
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 9 |
| Duplication | 4 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of the Castle Siege epic (#735).
Problem
During the battle, killing a player of another siege side made the killer an outlaw, unless both guilds happened to be declared rivals. Attacks also started the self-defense. Every siege fight between attackers and defenders was punished as a normal player kill.
Change
CastleSiegeContext.AreOnOpposingSides: two players are enemies when the siege is inStart, both are on the Castle Siege map with a side, and the sides differ. The attacking sides are enemies of each other as well.CastleSiegePlugInnow also implements the existingIPlayerKillPenaltyExemptionPlugInpoint (the same seam the Gens battle zone uses), so the exemption covers the kill penalty and the self-defense.Kills of the own side, and kills outside the battle, stay normal player kills.
Tests
New
CastleSiegePlayerKillTests(5 tests): side combinations, outside the battle, player off the siege map, exemption through the plugin manager, and the kill penalty for opposing vs. same side.Ran
dotnet test tests/MUnique.OpenMU.Tests --no-build --filter FullyQualifiedName~CastleSiegePlayerKillTests(5 passed). Not verified with a game client.Generated by Claude Code