Repository navigation
fix(castle-siege): only show the gate and statue list to owner officers - #1352
Open
icheat2win wants to merge 2 commits into
Open
icheat2win wants to merge 2 commits into
icheat2win wants to merge 2 commits into
Conversation
The gate and Guardian Statue list requests answered anyone, anywhere, with the health, upgrades and positions of the castle's defenses. They now need the Senior's window, like the other defense management requests, and the new CastleSiegeNpcListAction only lists the structures for the guild master and assistant master of the castle owner. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011xNc764bgrPZRQYCRzPj1x
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
| Duplication | -3 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
…npc-list-authorization # Conflicts: # docs-website/docs/server-features/castle-siege.md
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of the Castle Siege epic (#735).
Problem
The gate list and Guardian Statue list requests (
CastleSiegeNpcListHandlerBase) answered anyone, anywhere on the server, with the health, upgrade levels and positions of every castle defense. The handler also made the decision itself instead of delegating to a player action.Change
CastleSiegeNpcListAction.CastleSiegeNpcListActionlists the structures only for the guild master and assistant master of the castle owner (CastleSiegeNpcAuthorization.IsOwnerOfficerAsync, the same check as buying/upgrading). Other players get an empty list.No packet or view change: an unauthorized player gets the existing list packet with zero entries.
Tests
Two new tests in
CastleSiegeNpcTests: owner master gets the list, owner member / other guild master / guildless player get an empty list; the request without the Senior's window isn't answered.Ran the full
MUnique.OpenMU.Testssuite with--no-build: 2444 passed, 2 skipped. Not verified with a game client.Generated by Claude Code