Add Fashion crawler Postgres production wiring - #5
Draft
kaanyagci wants to merge 8 commits into
Draft
Conversation
There was a problem hiding this comment.
Pull request overview
This PR extends the shared PostgreSQL Swarm stack to support the Fashion crawler in production by attaching the production-only Fashion overlay network alias and ensuring the Fashion database/role are provisioned during production deploys, with docs and static validation updated to match.
Changes:
- Add a production-only
makepad-postgres-fashionservice alias backed by a new external overlay network variable (MAKEPAD_POSTGRES_FASHION_DB_NETWORK). - Provision the Fashion database/role during production deploys and introduce an idempotent bootstrap SQL script (
bootstrap/fashion-app.sql). - Update README documentation and the static validation script to enforce the new wiring and bootstrap expectations.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| scripts/validate-postgres-config.sh | Adds Fashion wiring/bootstrap invariants to the repo’s static configuration validation. |
| README.md | Documents the Fashion production network variable mapping, bootstrap invocation, and connection URI. |
| envs/production/compose.yml | Attaches Postgres to the production-only Fashion overlay network and exposes the makepad-postgres-fashion alias. |
| bootstrap/fashion-app.sql | New idempotent bootstrap to create/repair the fashion DB and fashion_crawler role using a password variable and advisory lock. |
| .github/workflows/manual-deploy.yml | Wires Fashion secrets/env vars, creates the Fashion overlay network in production, and provisions the Fashion DB/role with readiness checks. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
makepad-postgres-fashionfashiondatabase andfashion_crawlerrole during production deploysbootstrap/fashion-app.sqlpath and update docs/static validationValidation
bash scripts/validate-postgres-config.shMAKEPAD_POSTGRES_DB_NETWORK=catwlk-db MAKEPAD_POSTGRES_LE_PETIT_COIN_DB_NETWORK=le-petit-coin-db MAKEPAD_POSTGRES_VIF_DB_NETWORK=vif-db MAKEPAD_POSTGRES_FASHION_DB_NETWORK=fashion-db docker compose --env-file envs/production/.env.db -f compose.yml -f envs/production/compose.yml config >/tmp/makepad-postgres-stack.yml