Skip to content

chore(deps): upgrade Effect to 4.1.0 - #1956

Merged
Makisuo merged 2 commits into
mainfrom
chore/effect-4.1.0
Oct 30, 2026
Merged

Makisuo merged 2 commits into
mainfrom
chore/effect-4.1.0

test(scraper): advance the test clock until the send fiber exits

05921e4
Select commit
Loading
Failed to load commit list.
Maple Review Bot / Maple / review succeeded Oct 30, 2026 in 46s

Confidence 10/10 · No issues found

🟢 Confidence 10/10 · safe to merge
The only delta since the last review is a scraper test helper that reuses an existing repo idiom and still fails loudly if the fiber never exits.
no findings · tests covered · risk low

Bumps Effect and every @effect/* package to 4.1.0, regenerates the patches and adds a temporary alchemy patch for the effect/crypto move. The follow-up commit makes the scraper's retry and timeout tests advance the test clock until the send fiber exits. Safe to merge.

  • advanceUntilDone replaces the fixed tick count, polling the send fiber per clock step
  • Retry and timeout tests now stop advancing once the fiber has an exit
What was checked
  • Retry policy is two jittered backoffs (~0.5s, 1s), so one 2s step wakes it (apps/scraper/src/retry.ts:7)
  • pollUnsafe() is undefined while running, matching its other uses (apps/alerting/src/scheduled.test.ts:116)
  • Same Effect.repeat({ until, times }) idiom already used (apps/ai/src/platform/model-call-span.test.ts:837)

05921e4 · Updated on every push. Reply "won't fix" to dismiss a finding, or mention @maple-review-bot to ask about one.