Skip to content

test: prune UI tests that can't catch a bug, fix two that couldn't fail - #1957

Merged
Makisuo merged 2 commits into
mainfrom
chore/prune-ui-tests
Oct 30, 2026
Merged

test: prune UI tests that can't catch a bug, fix two that couldn't fail#1957
Makisuo merged 2 commits into
mainfrom
chore/prune-ui-tests

chore(local-ui): drop @foldkit/ui, unused after removing the tooltip …

4650952
Select commit
Loading
Failed to load commit list.
Maple Review Bot / Maple / review succeeded Oct 30, 2026 in 41s

Confidence 10/10 · No issues found

🟢 Confidence 10/10 · safe to merge
Test-only change: both rewritten assertions were checked against the hook's first-render return and the row link's aria-label, and each can now fail.
no findings · tests covered · risk low

Removes UI tests that duplicated covered behaviour or pinned layout option strings, and replaces two assertions that could never fail with ones that can. Test-only and safe to merge.

What was checked
  • usePlotLegendSlot derives its answer at render (plot-frame.tsx:452), so answers[0] is true and a read-back-from-effect regression now fails the test
  • role("link", { name: "Trace GET /" }) matches the row's aria-label built from rootSpanName (view-row.ts:31, row-link.ts:27)
  • The removed ELK assertions were constant-vs-literal pins on DEFAULT_LAYOUT_CONFIG, which the repo's test-slop rules ban; the flat/compound and >300-node switch checks stay

4650952 · Updated on every push. Reply "won't fix" to dismiss a finding, or mention @maple-review-bot to ask about one.

View more details on Maple Review Bot