Skip to content

fix(web): let an org with no plan link itself to the org that pays - #1958

Closed
Makisuo wants to merge 1 commit into
mainfrom
fix/billing-link-without-plan
Closed

Makisuo wants to merge 1 commit into
mainfrom
fix/billing-link-without-plan

fix(web): an org with no plan can reach billing settings to link itse…

124a68f
Select commit
Loading
Failed to load commit list.
Maple Review Bot / Maple / review succeeded Oct 30, 2026 in 1m 5s

Confidence 9/10 · No issues found

🟢 Confidence 9/10 · safe to merge
A two-line route exemption in the plan gate, pinned by a new plan-gate test; only the new link copy itself is untested.
no findings · tests partial −1 · risk medium

Lets an org with no plan open Settings → Billing through the plan gate, and points both plan pickers at that page with a "billed through another organization" link. The exemption is narrow and tested; safe to merge.

  • isAllowedWithoutPlan exempts Settings with tab=billing from the plan redirect
  • billThroughAnotherOrgLink adds the billing-settings link under both plan pickers
What was checked
  • Exemption is keyed on _tag === "Settings" && tab === "billing"; every other settings tab still redirects (plan-gate.ts:74)
  • The billing tab is visible to any Clerk viewer (page/settings/nav.ts:103), so syncTab does not rewrite the URL and bounce the org back to /settings
  • followRedirects reads the gate off model.route (update.ts:676), so the query-string tab the exemption keys on is the one the user navigated to

124a68f · Updated on every push. Reply "won't fix" to dismiss a finding, or mention @maple-review-bot to ask about one.