Skip to content

refactor(web): one route-tab strip, row link, sheet header and page title - #1986

Merged
Makisuo merged 3 commits into
ui-consistency-1from
ui-consistency-2
Oct 30, 2026
Merged

Makisuo merged 3 commits into
ui-consistency-1from
ui-consistency-2

Merge branch 'ui-consistency-1' into ui-consistency-2

8fb880c
Select commit
Loading
Failed to load commit list.
Maple Review Bot / Maple / review succeeded Oct 30, 2026 in 57s

Confidence 10/10 · No issues found

🟢 Confidence 10/10 · safe to merge. Only base-branch files changed since the last review and they are not in this diff; the earlier strip-scrolling and title-wrapping fixes are present at the head.
no findings · tests covered · risk medium

Consolidates four web layout primitives — route-tab strip, row link, sheet header and page title — into the kit and moves ~30 pages onto them. The substitutions are faithful (same classes, attributes and roles) and nothing in the diff is unsafe to merge.

  • linkTabStrip gains icon, count/countTone and onClick, and every route-tab strip now renders through it
  • rowLink and ROW_LINK_LIFT replace the four copied stretched-link class strings
  • sheetDetailHeader takes segmented kinds and an adornment; peek, review and action sheets use it
  • pageTitle/pageHeroParts put every page <h1> on pageTitleStyles
What was checked
  • Narrow strips still scroll: underlineTabStrip keeps overflow-x-auto and tabs stay shrink-0 (underline-tabs.ts:27, :39)
  • dashboardPage already renders the tabs slot inside the sticky area, so investigations' sticky:→tabs: move keeps the strip in place (dashboard-page.ts:180)
  • No ROW_STRETCHED_LINK_CLASS reference survives at the head, and rowLink composes the identical overlay classes

8fb880c · Reply "won't fix" to dismiss a finding, or mention @maple-review-bot to ask about one.