Skip to content

style(web): theme-safe colours and one source for brand accents - #1991

Merged
Makisuo merged 2 commits into
mainfrom
fix/design-consistency-pass-1
Oct 30, 2026
Merged

Makisuo merged 2 commits into
mainfrom
fix/design-consistency-pass-1

Conversation

@Makisuo

@Makisuo Makisuo commented Oct 30, 2026 •

Copy link
Copy Markdown
Collaborator

First pass from a dashboard consistency review. It fixes a colour that broke dark mode and removes duplicated brand-accent maps. Status colours, opacity levels and column widths are left to #1992, which covers them.

Changes

  • Tool input wash shows in dark mode. In an agent session's expanded tool call, the "Sent" half used bg-black/[0.06], which disappears on a dark background. It now uses bg-muted/50, the most common wash in the app.

    Before After
    Dark
    Light
  • One source for trace platform accents. The trace waterfall and the span panel each had a hand copy of the database brand colours and the Cloudflare orange, because the originals in @maple/ui import React icons. The colours now live in a React-free @maple/ui/lib/cloud-platforms/accents.ts, imported by all four consumers. The values moved unchanged, so this has no visual effect, and no lab fixture renders database spans in the waterfall to screenshot.

  • One RAILWAY_ACCENT, in integrations/catalog.ts (it was also declared in infra-integrations/kit/integration-empty.ts).

The SQL query badge fix from the first version of this PR was dropped because #1992 makes the same change. tool-io.ts also has a one-line overlap with #1992; once #1992 merges, this wash becomes bg-surface-sunken (the same 50% muted).

Verification

  • bun run typecheck passes in apps/web and packages/ui.
  • cloud-platforms.test.ts (12 tests) passes, and so do the worst-case lab and shortcut tests that touch the trace views.
  • oxlint (.oxlintrc.effect.json): no new findings on the changed files.
  • Screenshots: /lab/agent-session → Transcript → expand read_file, captured headless at 2x against origin/main and this branch, in light and dark.

🤖 Generated with Claude Code

- Trace waterfall and span panel read DB and Cloudflare accents from a React-free
  @maple/ui module instead of two hand copies of the adapter maps.
- One RAILWAY_ACCENT (integrations catalog) instead of two.
- SQL query badges use text-primary-foreground on bg-primary, and the agent
  session tool input wash uses bg-muted/50 so it shows in dark mode.
@coderabbitai

coderabbitai Bot commented Oct 30, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 6 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 4 included reviews currently available.

Learn how review limits work.

Review configuration:

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: c1647fd6-6a22-4f3d-966b-e8c82ce1607c
Commits

Reviewing files that changed from the base of the PR and between c0b5b4c and b73d795.

Files selected for processing: 9
  • apps/web/src/page/agent-sessions/session/tool-io.ts
  • apps/web/src/page/infra-integrations/kit/integration-empty.ts
  • apps/web/src/page/infra-integrations/railway/list/view.ts
  • apps/web/src/page/integrations/view-railway.ts
  • apps/web/src/page/traces/detail/span-panel/platform.ts
  • apps/web/src/page/traces/detail/waterfall/platform.ts
  • packages/ui/src/lib/cloud-platforms/accents.ts
  • packages/ui/src/lib/cloud-platforms/cloudflare.ts
  • packages/ui/src/lib/cloud-platforms/database.ts
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@maple-review-bot

This comment has been minimized.

The same text-primary-foreground swap is in the opacity-ladder PR; keeping it in
one place avoids a conflict on identical lines.
Makisuo added a commit that referenced this pull request Oct 30, 2026
@Makisuo Makisuo added the preview:web Deploy a Workers-only PR preview (no ingest/Electric); see docs/pr-previews.md label Oct 30, 2026
@Makisuo
Makisuo deployed to pr-preview October 30, 2026 20:24 — with GitHub Actions Active
@maple-review-bot

maple-review-bot Bot commented Oct 30, 2026 •

Copy link
Copy Markdown

Maple review

🟢 Confidence 10/10 · safe to merge. Pure constant/exports dedupe with identical values; the SQL-badge recolour that changed paint is no longer in the head.
no findings · tests not needed · risk low

Moves the trace waterfall and span-panel brand accents into a React-free @maple/ui/lib/cloud-platforms/accents.ts, drops the second RAILWAY_ACCENT, and swaps the agent tool-input bg-black/[0.06] wash for bg-muted/50. Values are unchanged and the moved classes are still generated; safe to merge.

  • accents.ts becomes the only source of the 18 db.system accent classes and the Cloudflare accent
  • RAILWAY_ACCENT now comes from integrations/catalog.ts in both Railway views
  • The agent tool-input half uses bg-muted/50 instead of the dark-mode-invisible bg-black/[0.06]

b73d795 · What was checked, coverage and telemetry details are on the Maple / review check. Reply "won't fix" to dismiss a finding, or mention @maple-review-bot to ask about one.

@github-actions

github-actions Bot commented Oct 30, 2026 •

Copy link
Copy Markdown
Contributor

🍁 Maple PR preview

Note

Preview resources were removed when the preview label came off.

Final commit b73d795 · View workflow run

@Makisuo
Makisuo deployed to pr-preview October 30, 2026 20:29 — with GitHub Actions Active
@Makisuo

Makisuo commented Oct 30, 2026

Copy link
Copy Markdown
Collaborator Author

Preview check (app-pr-1991.maple.dev, signed in as the preview reviewer, headless Chromium at 2x, light and dark)

  • Database accents from the shared module: pass. Trace 96d669ca (pg.query, db.system.name=postgresql): the waterfall row icon and the span panel's "PostgreSQL" header both carry text-[#336791] and render in Postgres blue (rgb 51,103,145) in both themes. The demo data has no Cloudflare Worker spans, so the orange accent couldn't be checked live.

    Dark Light
  • Tool input wash: not testable on the preview, because the Preview org has no agent sessions. The deployed CSS ships bg-muted/50 and no longer ships bg-black/[0.06]. The lab before/after in the description covers the rendering.

  • Railway accent: /infra/railway (connect empty state), /sources/new?integration=railway and /integrations render with no page errors.

  • Smoke: /, /traces, /logs, /errors and /services render with data and no JavaScript errors. The only console errors are 503s from the preview's sync service (sync-pr-1991), which isn't deployed with preview:web and is unrelated to this PR.

Traces: this PR changes only classes and constants in the browser bundle. It adds no backend code path or query, so there are no new spans to inspect.

@Makisuo Makisuo removed the preview:web Deploy a Workers-only PR preview (no ingest/Electric); see docs/pr-previews.md label Oct 30, 2026
@Makisuo
Makisuo deployed to pr-preview October 30, 2026 20:54 — with GitHub Actions Active
@Makisuo
Makisuo merged commit 38f12ba into main Oct 30, 2026
41 checks passed
@Makisuo
Makisuo deleted the fix/design-consistency-pass-1 branch October 30, 2026 21:21

This branch was successfully deployed

1 active deployment
pr-preview — b73d7952 Deployed Oct 30, 2026 by Makisuo via deploy-pr-preview #7956
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant