Skip to content

feat(web): text link, card button and dashed button in the kit - #1993

Merged
Makisuo merged 7 commits into
mainfrom
feat/kit-link-card-buttons
Oct 30, 2026
Merged

Makisuo merged 7 commits into
mainfrom
feat/kit-link-card-buttons

fix(web): uptime kind picker wraps on narrow screens like the old track

5da7b35
Select commit
Loading
Failed to load commit list.
Maple Review Bot / Maple / review succeeded Oct 30, 2026 in 18s

Confidence 8/10 · No issues found

🟢 Confidence 8/10 · likely safe to merge. Held at 8 because earlier reviews of this pull request found 2 defects.
no findings · tests covered · risk medium · 2 defects fixed in earlier rounds

Since the last review only the uptime kind picker moved: it now passes className: "w-fit flex-wrap" to segmentedSelect, so the four labelled kinds wrap onto a second row on narrow screens as the old hand-built track did. Safe to merge.

Fixed since the last review

  • ✅ F3 · Kind picker loses flex-wrap, so four labelled segments overflow on phones
What was checked
  • flex-wrap overrides the track's default nowrap because the caller's className is merged last (ui/segmented-select.ts:143)
  • Segments are shrink-0 (packages/ui/src/components/ui/toggle.styles.ts:5), so the track wraps instead of overflowing
  • Disabled kinds keep tabIndex: -1, so edit mode still tab-reaches only the current kind (ui/segmented-select.ts:173)

5da7b35 · Reply "won't fix" to dismiss a finding, or mention @maple-review-bot to ask about one.