Skip to content

style(web): toolbar searches at the toolbar size, page gaps through dashboardPage - #1994

Merged
Makisuo merged 3 commits into
mainfrom
style/toolbar-heights-page-gap
Oct 30, 2026
Merged

style(web): toolbar searches at the toolbar size, page gaps through dashboardPage#1994
Makisuo merged 3 commits into
mainfrom
style/toolbar-heights-page-gap

fix(web): templates readiness filter, tag filter and metric type sele…

d26adec
Select commit
Loading
Failed to load commit list.
Maple Review Bot / Maple / review succeeded Oct 30, 2026 in 1m 0s

Confidence 8/10 · No issues found

🟢 Confidence 8/10 · likely safe to merge. Held at 8 because earlier reviews of this pull request found 3 defects.
no findings · tests not needed · risk low · 3 defects fixed in earlier rounds

Parent styling pass: eight list toolbars move their search (and the dashboards selects/buttons) to size: "sm", and 18 pages swap hand-written scrollClassName: "gap-6"/"gap-4" for gap: "lg"/"md" on dashboardPage. The classes that reach the DOM are unchanged apart from the intended 32→28px controls, so it is safe to merge.

  • searchInput in eight list toolbars now passes size: "sm"
  • Dashboards scope/sort/tags controls and templates readiness filter drop to sm
  • Investigations and metrics selects take size: "sm"
  • 18 pages use dashboardPage's gap: "lg" | "md" instead of scrollClassName
What was checked
  • PAGE_GAP maps lg→gap-6, md→gap-4, applied to page-scroll-area (dashboard-page.ts:123, :139); no changed call site passes width or fill, so the element is the one scrollClassName …
  • searchInput, select-view and segmentedSelect all declare size: "sm" (search-input.ts:17, select-view.ts:55, segmented-select.ts:125)
  • The ...titleRow(...) spreads in cloudflare and GCP list pages return only titleContent/actions/tabs, so they cannot override gap (cloudflare/list/view.ts:479)

d26adec · Reply "won't fix" to dismiss a finding, or mention @maple-review-bot to ask about one.

View more details on Maple Review Bot