Repository navigation
style(web): neutral dots, hover fills, card outlines and off-scale spacing on tokens - #1999
Conversation
…acing on tokens Third consistency pass after #1988 and #1992. - Neutral status fills and outline rings: bg/border-muted-foreground/30..75 become foreground-subtle (50% and up) or foreground-faint. - Dividers: bg-border/20, /40, /60 become bg-border-subtle. - Card hover and selected outlines: new border-border-strong token (foreground 30%). - Row and button hovers: accent/50, foreground/5, /8, /[0.06] become surface-sunken. - rounded-[2px] and rounded-[3px] become rounded-xs. - Off-scale gaps and padding snap to the spacing scale; name-column min widths use the 16px width scale.
Maple review🟢 Confidence 10/10 · safe to merge. Every token and utility the pass introduces resolves against the shared theme, and no logic, state or data path changes. A visual-only Tailwind pass: neutral fills, dividers, hover fills, radii, gaps and name-column widths move onto the existing scales, plus one new
|
|
Caution Review failedThe pull request is closed. Walkthrough
Merge Risk:
|
Third consistency pass, after #1988 and #1992. It moves the spacing, colour and token drift those two left on
mainonto the existing scales and adds one token.Changes
bg-muted-foreground/30to/75bg-foreground-subtle(50% and up) orbg-foreground-faintborder-muted-foreground/30to/70border-foreground-subtleorborder-foreground-faintborder-foreground/30and/40border-border-strong(foreground 30%)bg-border/20,/40,/60bg-border-subtleaccent/50,foreground/5,/8,/[0.06],/[0.02]hover:bg-surface-sunken(already used in 116 places)rounded-[2px],rounded-[3px]mixed withrounded-xsrounded-xsgap-[9px],gap-[5px],pt-[22px],px-[5px]...gap-2,gap-1.5,py-5,px-1.5min-w-44...min-w-64)Left as is on purpose: graded data ramps (latency tones, range histogram, Railway band), chart tracks and skeletons (already consistent), brand colours, white text on filled badges, and pixel offsets that align dots or tree lines.
Screenshots
From the
/labfixture routes at 1440px,main(35e3b34) on the left and this branch on the right.Agent tools (
/lab/agent-tools): chart header padding 22px to 20px, matching the bottomAlerts (
/lab/alerts): held-rule fill on the shared neutral tokenSecurity (
/lab/security): tab icon gap 7px to 8pxFull frames, before and after:
The hover changes (card outlines, row hovers) only show on pointer-over and are not in these static frames.
Verification
bun run --filter=@maple/web typecheckpasses.oxlint -c .oxlintrc.effect.jsonon the changed files: no errors.🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need.Summary by CodeRabbit