timely-util: fix settle carry threshold test - #38073
Merged
Merged
Conversation
`settle_carry_commits_at_target` sized its chunks assuming a 24-byte row, but the test row has four fixed-width leaves and serializes to 32 bytes. Chunks came out at ~2.0 MiB, above `at_commit_size`, so settle committed all four as-is and the carry never coalesced. The monotone and the old windowed predicate agree at that size, so the test could not catch a revert to the windowed form it exists to guard. Size chunks at ~1.5 MiB so the carry has to coalesce, and assert that coalescing happened so the fixture cannot drift back over the threshold silently. Follow-up to MaterializeInc#37955. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
settle_carry_commits_at_targetsized its chunks assuming a 24-byte row, but the test row has four fixed-width leaves and serializes to 32 bytes. Chunks came out at ~2.0 MiB, aboveat_commit_size, so settle committed all four as-is and the carry never coalesced. The monotone and the old windowed predicate agree at that size, so the test could not catch a revert to the windowed form it exists to guard.Size chunks at ~1.5 MiB so the carry has to coalesce, and assert that coalescing happened so the fixture cannot drift back over the threshold silently.
Follow-up to #37955.