Repository navigation
Conversation
Smoke runs settle on process exit instead of waiting for the output pipes, so LibreOffice's soffice.bin can no longer hold the check open (the 45 minute hang). Each run is killed as a tree after 90 s and reported by name, LibreOffice runs with a throwaway profile, and both workflow steps get a 10 minute limit. Closes #43 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #43.
Cause: verify-bundle ran each tool with execFileSync. Its 120 s timeout only kills the direct child, and execFileSync then keeps waiting for the stdout/stderr pipes to close. LibreOffice's soffice.com starts soffice.bin, which inherits those pipes, so the step could wait forever (the 45 min stall on #42's dry run).
Fix:
Verification: node scripts/verify-bundle.mjs resources and dist/win-unpacked/resources both pass locally in about 7 s, LibreOffice included. This PR's release dry run exercises the new script on CI.
🤖 Generated with Claude Code