merge queue: checking main (93c5b32) and #12334 together - #12336
Closed
mergify[bot] wants to merge 2 commits into
Closed
merge queue: checking main (93c5b32) and #12334 together#12336mergify[bot] wants to merge 2 commits into
mergify[bot] wants to merge 2 commits into
Conversation
The engine flags a schema node as a documented data type, and on the configuration side `ConfigOptions` turns that flag into a link to the matching section of the data-types page. The API reference publishes the same flag and did nothing with it: `BatchStatus.code` rendered its twelve values with no explanation and no pointer to the section that explains them — the state documenting it was meant to fix, on the page a reader most likely arrives from. That left the convention enforcing something nobody consumed. The build fails when a marked title has no matching heading, so the anchor was being maintained for a link the API side never rendered. Render "see <data type>" beside the values. The values stay: an API consumer needs to know what a field accepts, and the marker only says their meaning is written up elsewhere. The type label is deliberately left alone. Substituting a title for the accepted values there is exactly the regression that hoisting shared enums into components caused for fifteen query parameters, and a marked type used as a parameter would reintroduce it. The flag is read from the referring node as well as the `$ref` target, because pydantic publishes it inline for an inlined type and as a `$ref` sibling for a hoisted one. Part of MRGFY-8330 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Change-Id: I23de38ed505614420d6ca72d376424621b1c9c7a
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎉 This pull request has been checked successfully and will be merged soon. 🎉
Branch main (93c5b32) and #12334 are queued together for merge.
This pull request has been created by Mergify to check the mergeability of #12334.
You don't need to do anything. Mergify will close this pull request automatically when it is complete.
Required conditions of queue rule
defaultfor merge:github-review-approved[🛡 GitHub repository ruleset ruleRequire pull request for default branch]schedule=Mon-Fri 09:00-17:30[Europe/Paris]Enforce conventional commit]:title ~= ^(fix|feat|internal|docs|style|refactor|perf|test|build|ci|chore|revert|ui)(?:\(.+\))?!?:👀 Review Requirements]:#approved-reviews-by >= 2author = dependabot[bot]author = mergify-ci-bot-head ~= ^docs-agent/📕 PR description]:body ~= (?ms:.{48,})🔎 Reviews]:#changes-requested-reviews-by = 0#review-requested = 0#review-threads-unresolved = 0🤖 Continuous Integration]:check-success = buildcheck-success = lintcheck-success = testcheck-success = test-broken-linkslabel = ignore-broken-linkscheck-success=Cloudflare Pages-head-repo-full-name~=^Mergifyio/Required conditions to stay in the queue:
github-review-approved[🛡 GitHub repository ruleset ruleRequire pull request for default branch]Enforce conventional commit]:title ~= ^(fix|feat|internal|docs|style|refactor|perf|test|build|ci|chore|revert|ui)(?:\(.+\))?!?:👀 Review Requirements]:#approved-reviews-by >= 2author = dependabot[bot]author = mergify-ci-bot-head ~= ^docs-agent/📕 PR description]:body ~= (?ms:.{48,})🔎 Reviews]:#changes-requested-reviews-by = 0#review-requested = 0#review-threads-unresolved = 0🤖 Continuous Integration]:check-success = buildcheck-success = lintcheck-success = testcheck-success = test-broken-linkslabel = ignore-broken-linkscheck-success=Cloudflare Pages-head-repo-full-name~=^Mergifyio/author != dependabot[bot]author != mergify-ci-bothead ~= ^docs-agent/