Skip to content

Fix build issues for upcoming ioda changes. - #298

Merged
Matt Shin (matthewrmshin) merged 1 commit into
developfrom
bugfix/missing_ioda_headers
Sep 15, 2026
Merged

Matt Shin (matthewrmshin) merged 1 commit into
developfrom
bugfix/missing_ioda_headers

Conversation

@lewisn-met

@lewisn-met lewisn-met commented Sep 15, 2026 •

Copy link
Copy Markdown
Contributor

This PR adds missing includes to the GnssroStationID class which would otherwise cause build failures and warnings when the IODA PR https://github.com/JCSDA-internal/ioda/pull/1869 is merged.

Merge before: https://github.com/JCSDA-internal/ioda/pull/1869

@matthewrmshin

Copy link
Copy Markdown
Collaborator

I guess this one can go in before https://github.com/JCSDA-internal/ioda/pull/1869?

@lewisn-met

Copy link
Copy Markdown
Contributor Author

I guess this one can go in before JCSDA-internal/ioda#1869?

Indeed, now added to description! Actually, this is necessary if we don't want build failures, so thanks for checking :D

@matthewrmshin
Matt Shin (matthewrmshin) merged commit 242700e into develop Sep 15, 2026
2 checks passed
@matthewrmshin
Matt Shin (matthewrmshin) deleted the bugfix/missing_ioda_headers branch September 15, 2026 14:23
Matt Shin (matthewrmshin) added a commit that referenced this pull request Sep 16, 2026
Also add cpplint to regular lint GH Actions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working coordinate merge Pull requests that require coordination with pull requests in other repos

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants