Varobs cx xios fix - #300
Open
Jonas Ganderton (mo-jonasganderton) wants to merge 3 commits into
Open
Jonas Ganderton (mo-jonasganderton) wants to merge 3 commits into
Jonas Ganderton (mo-jonasganderton) wants to merge 3 commits into
Conversation
Jonas Ganderton (mo-jonasganderton)
requested a review
from Steven Sandbach (ss421)
October 1, 2026 15:06
Jonas Ganderton (mo-jonasganderton)
marked this pull request as ready for review
October 2, 2026 10:09
Chris Thomas (ctgh)
approved these changes
Oct 2, 2026
Chris Thomas (ctgh)
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for the fix!
David Davies (DJDavies2)
approved these changes
Oct 2, 2026
Collaborator
|
Jonas Ganderton (@mo-jonasganderton) can you try retriggering the CI please? |
Jonas Ganderton (mo-jonasganderton)
marked this pull request as draft
October 5, 2026 10:45
Jonas Ganderton (mo-jonasganderton)
marked this pull request as ready for review
October 5, 2026 10:45
Author
|
Chris Thomas (@ctgh) Just tried a few times, including with debug mode. It always seems to skip the gnu-openmpi check? |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Enables the Varobs Writer and CX Writer filters to work when XIOS is used in server mode.
Done by switching from using mpl_comm_world to mpi_group in the relevant filters.
Testing
mo-bundle tests
I've tested malak kgo_glu_jopa_jada using XIOS in server mode, this results in KGO changes for JOPA and JADA. This is not the default behaviour, but demonstrates this works should we want to change.
This was done using a couple of custom branches - these are not designed for merging, primarily because I've taken the 4dvar iodef for testing purposes.
Resolves