Repository navigation
Conversation
…ng-library-clean ; Conflicts: ; tools/deployment-cli-tools/ch_cli_tools/configuration/preprocessing.py ; tools/deployment-cli-tools/tests/test_helm.py ; tools/deployment-cli-tools/tests/test_preprocessing.py
aranega
marked this pull request as ready for review
October 27, 2026 15:07
filippomc
force-pushed
the
poc/ng-library-clean
branch
from
October 30, 2026 17:52
fe844cc to
247894c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implemented solution
Introduces an entity-graph model representing a CloudHarness project's apps, images, tasks, and config layering, replacing the previous dict/function-based generator.
Helm chart, Codefresh pipeline, Skaffold, Tilt, docker-compose, and VS Code debug-config generation are all rebuilt on top of this model instead of the old ad-hoc traversal code.
This PR completes the migration: the new model (formerly
ch_cli_tools/ng/) is now theonly implementation.
harness-deploymentis the single entrypoint, and the old dict-based generator, its parallel test suite, andharness-deployment-legacyhave been ported after verifying line-by-line parity against the legacy test suite (full history and exact removals/gaps inPORT_NOTES.mdattached to the PR).Notable fixes that came out of building/verifying the new model:
double-nested checkout path (e.g. GitHub Actions'
work/<repo>/<repo>/), which previouslypointed generated scripts at the wrong working directory.
test-e2e,test-api) now get a real content-hash tag instead offalling back to
latest, so they correctly trigger rebuilds when their content changes.ignored directories like
node_modulesbefore filtering, and content hashing usesxxhashinstead of SHA1 for a large speedup on big trees (~19x faster measured on a huge file structure).setup.py/requirements.txttopyproject.toml.Not a breaking change for deployed CloudHarness projects. Generated Helm/Codefresh/Skaffold/Tilt/compose output is intended to match the legacy generator's output for all existing configurations covered by the test suite.
How to test this PR
Run the full test suite from
tools/deployment-cli-tools:All tests should pass (no known failures).
For an end-to-end sanity check against a real project, run harness-deployment against
an actual deployment (e.g. the natus-hfo-tools project) and confirm it completes
successfully and produces the expected Helm chart / Codefresh pipeline / Skaffold config:
Sanity checks:
Breaking changes (select one):
breaking-changeand the migration procedure is well described abovePossible deployment updates issues (select one):
alert:deployment(this is a refactoring of the deployment feature, so it's worth checking any deployment issue)Test coverage (select one):
Documentation (select one):
Nice to have (if relevant):
PORT_NOTES.md