Fix JSON formatting in FuraCoin metadata - #1890
Conversation
Add token metadata
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 6f6a1ea. Configure here.
|
|
||
| "erc20": true, | ||
|
|
||
| "logo": "./icons/eip155:1/erc20:0xe1631864495a2251Ae092d678111ACE32eE28aD4.png"} |
There was a problem hiding this comment.
Missing referenced token logo
High Severity
The logo field points to ./icons/eip155:1/erc20:0xe1631864495a2251Ae092d678111ACE32eE28aD4.png, but that icon file is not present in the repository. Token metadata is incomplete without the image, so the logo cannot render and asset verification/test/caip.js logo existence checks fail.
Reviewed by Cursor Bugbot for commit 6f6a1ea. Configure here.
…20:0xe1631864495a2251Ae092d678111ACE32eE28aD4.png
Add files via upload
|
He añadido el logo en icons/eip155:1/erc20/0xe1631864495a2251Ae092d678111ACE32eE28aD4.png para completar la metadata y resolver la advertencia del bot. Por favor, re-ejecuten los checks y revisen cuando puedan. Contacto: roselemerald@gmail.com / investment@emeraldstrade.com Comentario corto en inglés (si prefieres)Added the logo at icons/eip155:1/erc20/0xe1631864495a2251Ae092d678111ACE32eE28aD4.png to complete the metadata and fix the Cursor bot warning. Please re-run checks and review when possible. Contacts: roselemerald@gmail.com / investment@emeraldstrade.com |
… JSON - Place logo at icons/eip155:1/erc20:0xe163...D4.png (matches metadata logo field) - Remove misplaced root-level PNG from earlier upload - Normalize JSON formatting (no blank lines, proper closing brace)
Fix appliedResolved the Missing referenced token logo finding:
Please re-run checks / re-review. Contacts: roselemerald@gmail.com / investment@emeraldstrade.com |
Path note (please ignore any guide saying otherwise)The correct logo path uses a colon in the filename, not a ✅ Correct (what is in this PR now): ❌ Incorrect (do not upload here): Metadata |
|
He añadido el logo en la ruta referenciada y se han eliminado duplicados; la imagen es 256×256 PNG (RGBA). ¿Podrían re-ejecutar los checks y revisar/aprobar cuando puedan? Gracias. |
|
ES:@MRabenda urgente por favor — necesitamos que se aprueben los workflows en PR #1890 para que los checks se ejecuten. El logo ya está en icons/eip155:1/erc20/0xe1631864…png y tenemos ticket de soporte #120870179 solicitando revisión manual/escalado. ¿Podrías ayudar a aprobar y revisar pronto? Gracias. |
|
ESCALADO URGENTE - PR #1890 Bloqueado PR: #1890 - MetaMask/contract-metadata Solicito: Revisión manual urgente / Escalado a equipo superior Ticket de soporte: #120870179 |
|
Thank you for being patient. |
|
Thanks for the information, Ego.To properly plan the project's growth, could you let us know what approximate criteria MetaMask uses to determine if a token has sufficient activity to approve the metadata pull request (PR) and display the logo to all users?We understand you mentioned that the token's activity is currently very limited, and we would like to know if there is a general benchmark—such as a specific number of transactions, volume, number of holders, or a certain period of activity—that we should aim to reach before expecting PR approval.We aren't trying to rush the process; rather, we want to understand what level of activity is typically considered sufficient for this type of review.Thank you very much for your guidance.Sent from my iPhoneOn Aug 6, 2026, at 3:27 AM, Emil Pop ***@***.***> wrote:epop-cs left a comment (MetaMask/contract-metadata#1890)
@Furacoin168,
Thank you for being patient.
We are trying to merge only what makes sense for the community (it is subjective).
After reviewing the token's activity, we noticed that it has 1 transfer every 20 days. So it does not fit our criteria.
Our team will merge it once this token has better traction.
Thank you for being understanding.
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: ***@***.***>
|
3 participants
Add token metadata
Note
Low Risk
Static token metadata only; no runtime or security-sensitive code changes.
Overview
Adds FuraCoin (
FURA, 18 decimals) to the Ethereum mainnet ERC-20 catalog at contract0xe1631864495a2251Ae092d678111ACE32eE28aD4, using the same metadata shape as other tokens (name,symbol,decimals,erc20,logopath under./icons/...).Reviewed by Cursor Bugbot for commit 874bbb4. Bugbot is set up for automated code reviews on this repo. Configure here.