Conversation
…bscription; first pass
…ature-flag-in-money-account-balance-service
Matt561
changed the title
…ature-flag-in-money-account-balance-service
Contributor
Author
|
@metamaskbot publish-previews |
Contributor
|
Preview builds have been published. Learn how to use preview builds in other projects. Expand for full list of packages and versions. |
Jwhiles
approved these changes
May 8, 2026
Contributor
Jwhiles
left a comment
Jwhiles
left a comment
There was a problem hiding this comment.
Nice! I like the approach - will do something similar for the chomp and upgrade controller packages :)
Matt561
deleted the
feat/musd-681-support-remote-vault-config-feature-flag-in-money-account-balance-service
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
This PR updates the
@metamask/money-account-balance-serviceto use a remote vault config instead of constructor args.References
Checklist
Note
Medium Risk
Breaking API changes shift vault configuration from constructor args to
RemoteFeatureFlagControllerstate and alter response shapes, which can break consumers and affect balance/APY lookups until flags are available. Runtime behavior now depends on async flag delivery and validation, adding new error paths and cache invalidation logic.Overview
Refactors
MoneyAccountBalanceServiceto stop taking vault config in the constructor and insteadinit()/subscribe toRemoteFeatureFlagController(getState+stateChange) for a remotemoneyAccountVaultConfig, throwingVaultConfigNotAvailableErroruntil a valid config is present and routing malformed configs viaVaultConfigValidationError.Updates on-chain/API fetching to use the new config shape (
boringVault,chainId,lensAddress,tellerAddress, etc.), including switchinggetMusdEquivalentValueto call the Lens contract’sbalanceOfInAssetsand tighteninggetVaultApyto error when the chain ID lacks aVEDA_API_NETWORK_NAMESmapping (adds Monad). Adds corresponding structs/types, logging, exports, dependency on@metamask/remote-feature-flag-controller, and extensive test coverage for config lifecycle and cache invalidation.Reviewed by Cursor Bugbot for commit 5e603a6. Bugbot is set up for automated code reviews on this repo. Configure here.