Skip to content

fix: emit backup and sync trace only when mutations occur #9343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mathieuartu wants to merge 6 commits into
base: main
Choose a base branch
from
Open

fix: emit backup and sync trace only when mutations occur #9343

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
fe54f70
fix: emit backup and sync trace only when mutations occur
mathieuartu Jul 1, 2026
7b05155
fix: update CHANGELOG
mathieuartu Jul 1, 2026
d55336f
fix: API changes and address feedbacks
mathieuartu Jul 3, 2026
79e5515
fix: address cursor feedbacks
mathieuartu Jul 3, 2026
e821888
fix: remove clutter
mathieuartu Jul 3, 2026
ef063ff
Merge branch 'main' into fix/backup-sync-spans
mathieuartu Jul 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion eslint-suppressions.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@
"count": 1
},
"n/no-sync": {
"count": 22
"count": 29
}
},
"packages/account-tree-controller/src/backup-and-sync/service/index.ts": {
Expand Down
1 change: 1 addition & 0 deletions packages/account-tree-controller/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

### Changed

- The `Multichain Account Syncing - Full` trace is now only emitted when a backup-and-sync run actually mutates local or remote state (rolled-back local changes do not count) ([#9343](https://github.com/MetaMask/core/pull/9343))
- Bump `@metamask/keyring-api` from `^23.1.0` to `^23.3.0` ([#9249](https://github.com/MetaMask/core/pull/9249))
- Bump `@metamask/multichain-account-service` from `^11.0.0` to `^11.1.0` ([#9264](https://github.com/MetaMask/core/pull/9264))
- Bump `@metamask/accounts-controller` from `^39.0.3` to `^39.0.4` ([#9349](https://github.com/MetaMask/core/pull/9349))
Expand Down
2 changes: 2 additions & 0 deletions packages/account-tree-controller/src/AccountTreeController.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ import {
} from './backup-and-sync/analytics';
import { BackupAndSyncService } from './backup-and-sync/service';
import type { BackupAndSyncContext } from './backup-and-sync/types';
import { createSyncMutationTracker } from './backup-and-sync/utils';
import type { AccountGroupObject, AccountTypeOrderKey } from './group';
import {
ACCOUNT_TYPE_TO_SORT_ORDER,
Expand Down Expand Up @@ -1803,6 +1804,7 @@ export class AccountTreeController extends BaseController<
controllerStateUpdateFn: this.update.bind(this),
traceFn: this.#trace.bind(this),
groupIdToWalletId: this.#groupIdToWalletId,
mutationTracker: createSyncMutationTracker(),
};
}
}
Loading