Skip to content

fix: unhide tokens with low occurrences for some chains #9359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
maxime-oe wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: unhide tokens with low occurrences for some chains #9359

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 19 additions & 7 deletions packages/assets-controller/src/data-sources/TokenDataSource.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import type {
} from '@metamask/phishing-controller';
import { TokenScanResultType } from '@metamask/phishing-controller';
import { KnownCaipNamespace, parseCaipAssetType } from '@metamask/utils';
import type { CaipAssetType } from '@metamask/utils';
import type { CaipAssetType, CaipChainId } from '@metamask/utils';

import type { AssetsControllerMessenger } from '../AssetsController';
import { projectLogger, createModuleLogger } from '../logger';
Expand Down Expand Up @@ -44,6 +44,12 @@ const BULK_SCAN_BATCH_SIZE = 100;
*/
const MIN_TOKEN_OCCURRENCES = 3;

const MIN_TOKEN_OCCURRENCES_PER_CHAIN_OVERRIDE: { [key: CaipChainId]: number } =
{
// Arc: Chain not yet released so some important tokens (ex: EURC) have low occurrences.
'eip155:5042': 1,
};

/** CAIP-19 `assetNamespace` segments used across filtering logic. */
export enum CaipAssetNamespace {
Slip44 = 'slip44',
Expand Down Expand Up @@ -415,7 +421,7 @@ export class TokenDataSource {
metadataResponse.map((a) => [a.assetId, a.occurrences]),
);

const evmErc20Ids: string[] = [];
const evmErc20Ids: Caip19AssetId[] = [];
const nonEvmTokenIds: string[] = [];

for (const assetData of metadataResponse) {
Expand All @@ -440,12 +446,18 @@ export class TokenDataSource {
// can import whatever they want and we must keep their metadata even
// if the API has fewer than `MIN_TOKEN_OCCURRENCES` aggregator hits.
const allowedEvmIds = new Set(
evmErc20Ids.filter(
(id) =>
evmErc20Ids.filter((id) => {
// No exception handling herea as we already managed to parse it upstream.
const { chainId } = parseCaipAssetType(id);
const minOccurrences =
MIN_TOKEN_OCCURRENCES_PER_CHAIN_OVERRIDE[chainId] ??
MIN_TOKEN_OCCURRENCES;
return (
customAssetIds.has(id.toLowerCase()) ||
(occurrencesByAssetId.get(id) ?? 0) >= MIN_TOKEN_OCCURRENCES ||
id.includes(`/erc20:${MUSD_ADDRESS_LOWERCASE}`),
),
(occurrencesByAssetId.get(id) ?? 0) >= minOccurrences ||
id.includes(`/erc20:${MUSD_ADDRESS_LOWERCASE}`)
);
}),
);

// Non-EVM: Blockaid bulk scan.
Expand Down
Loading