-
-
Notifications
You must be signed in to change notification settings - Fork 288
feat(Stellar): asset enrichment through snap data source #9422
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
khanti42
wants to merge
5
commits into
main
Choose a base branch
from
feat/asset-balance-enrichment-snap
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
14e36eb
chore: asset enrichment through snap data source
khanti42 e20f4b2
chore: separate enrich logic in helper
khanti42 dac217f
fix: skip snap enrichment when unavailable
khanti42 31bb1f3
chore: simplify
khanti42 f39d837
chore: removed getSnapIdForChain
khanti42 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,6 @@ | ||
| { | ||
| "name": "@metamask/assets-controller", | ||
| "version": "10.0.1", | ||
| "version": "10.0.1-dev.8", | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Ah nice, didn't know you could do this for testing. Let's clean up |
||
| "description": "Tracks assets balances/prices and handles token detection across all digital assets", | ||
| "keywords": [ | ||
| "Ethereum", | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -84,7 +84,10 @@ import type { PriceDataSourceConfig } from './data-sources/PriceDataSource'; | |
| import { PriceDataSource } from './data-sources/PriceDataSource'; | ||
| import type { RpcDataSourceConfig } from './data-sources/RpcDataSource'; | ||
| import { RpcDataSource } from './data-sources/RpcDataSource'; | ||
| import type { AccountsControllerAccountBalancesUpdatedEvent } from './data-sources/SnapDataSource'; | ||
| import type { | ||
| AccountsControllerAccountBalancesUpdatedEvent, | ||
| SnapDataSourceConfig, | ||
| } from './data-sources/SnapDataSource'; | ||
| import { SnapDataSource } from './data-sources/SnapDataSource'; | ||
| import type { StakedBalanceDataSourceConfig } from './data-sources/StakedBalanceDataSource'; | ||
| import { StakedBalanceDataSource } from './data-sources/StakedBalanceDataSource'; | ||
|
|
@@ -428,6 +431,8 @@ export type AssetsControllerOptions = { | |
| priceDataSourceConfig?: PriceDataSourceConfig; | ||
| /** Optional configuration for StakedBalanceDataSource. */ | ||
| stakedBalanceDataSourceConfig?: StakedBalanceDataSourceConfig; | ||
| /** Optional configuration for SnapDataSource. */ | ||
| snapDataSourceConfig?: SnapDataSourceConfig; | ||
| /** | ||
| * Function returning whether onboarding is complete. When false, | ||
| * RPC and staked balance data sources skip fetch and subscribe | ||
|
|
@@ -574,7 +579,14 @@ function mergeAccountBalances( | |
| replaceCoveredChains: boolean, | ||
| ): Record<string, AssetBalance> { | ||
| if (!replaceCoveredChains) { | ||
| return { ...previousBalances, ...accountBalances }; | ||
| const next: Record<string, AssetBalance> = { ...previousBalances }; | ||
| for (const [assetId, balance] of Object.entries(accountBalances)) { | ||
| next[assetId] = { | ||
| ...(previousBalances[assetId] ?? { amount: '0' }), | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. still have amt 0? |
||
| ...balance, | ||
| }; | ||
| } | ||
| return next; | ||
| } | ||
|
|
||
| const coveredChains = new Set( | ||
|
|
@@ -848,6 +860,7 @@ export class AssetsController extends BaseController< | |
| accountsApiDataSourceConfig, | ||
| priceDataSourceConfig, | ||
| stakedBalanceDataSourceConfig, | ||
| snapDataSourceConfig, | ||
| isOnboarded, | ||
| }: AssetsControllerOptions) { | ||
| super({ | ||
|
|
@@ -900,6 +913,7 @@ export class AssetsController extends BaseController< | |
| this.#snapDataSource = new SnapDataSource({ | ||
| messenger: this.messenger, | ||
| onActiveChainsUpdated: this.#onActiveChainsUpdated, | ||
| ...snapDataSourceConfig, | ||
| }); | ||
| this.#rpcDataSource = new RpcDataSource({ | ||
| messenger: this.messenger, | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's add the PR number and link.