feat!: allow dynamic infura networks#9432
Draft
mikesposito wants to merge 3 commits into
Draft
Conversation
21722a6 to
ce206bd
Compare
Member
Author
|
@metamaskbot publish-preview |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
Currently,
NetworkControllermanages two types of network config:InfuraandCustom. TheInfuratype is dedicated to configurations with RPC endpoints with an Infura URL that uses a template string for the project ID, whileCustomconfigurations are generic network configurations that can be also added by users.In order to add a network configuration of Infura type to NetworkController, the network must first be added to
@metamask/controller-utilsto satisfyNetworkControllervalidations, or else it won’t be recognized as a known network, and the operation will fail with an error. This currently blocks us from leveraging mm-config-registry (Dynamic registry) from being used to add Infura network configurations remotely.This PR relaxes
NetworkControllervalidations to accept Infura configurations that are not included in@metamask/controller-utils, nor in any other bundled known list.References
Checklist