Skip to content

chore: drop bitrise.yml dependency #269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Cal-L merged 1 commit into from
Jul 1, 2026
Merged

chore: drop bitrise.yml dependency #269

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .github/actions/stable-sync/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,6 @@ runs:

Preserves specific files from the stable branch:
- CHANGELOG.md
- bitrise.yml
- android/app/build.gradle
- ios/MetaMask.xcodeproj/project.pbxproj
- package.json
Expand Down
2 changes: 1 addition & 1 deletion .github/scripts/create-platform-release-pr.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ get_expected_changed_files() {
local expected_changed_files=""

if [[ "$platform" == "mobile" ]]; then
expected_changed_files="package.json android/app/build.gradle ios/MetaMask.xcodeproj/project.pbxproj bitrise.yml"
expected_changed_files="package.json android/app/build.gradle ios/MetaMask.xcodeproj/project.pbxproj"
elif [[ "$platform" == "extension" ]]; then
expected_changed_files="package.json"
else
Expand Down
42 changes: 14 additions & 28 deletions .github/scripts/set-mobile-build-version.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ SEMVER_REGEX="\

PACKAGE_JSON_FILE=package.json
ANDROID_BUILD_GRADLE_FILE=android/app/build.gradle
BITRISE_YML_FILE=bitrise.yml
IOS_PROJECT_FILE=ios/MetaMask.xcodeproj/project.pbxproj

semver_to_nat () {
Expand All @@ -51,12 +50,6 @@ update_mobile_files () {
sed -i '' -E "s/(\s*versionCode )[0-9]+/\1$VERSION_NUMBER/" $ANDROID_BUILD_GRADLE_FILE
echo "- $ANDROID_BUILD_GRADLE_FILE successfully updated"

# update bitrise.yml
echo "Updating Bitrise configuration files..."
sed -i '' -E "s/(\s*VERSION_NUMBER: )[0-9]+/\1$VERSION_NUMBER/" $BITRISE_YML_FILE
sed -i '' -E "s/(\s*FLASK_VERSION_NUMBER: )[0-9]+/\1$VERSION_NUMBER/" $BITRISE_YML_FILE
echo "- $BITRISE_YML_FILE successfully updated"

# update ios/MetaMask.xcodeproj/project.pbxproj
echo "Updating iOS project settings..."
sed -i '' -E "s/(\s*CURRENT_PROJECT_VERSION = )[0-9]+/\1$VERSION_NUMBER/" $IOS_PROJECT_FILE
Expand All @@ -70,12 +63,6 @@ update_mobile_files () {
sed -i -E "s/(\s*versionCode )[0-9]+/\1$VERSION_NUMBER/" $ANDROID_BUILD_GRADLE_FILE
echo "- $ANDROID_BUILD_GRADLE_FILE successfully updated"

# update bitrise.yml
echo "Updating Bitrise configuration files..."
sed -i -E "s/(\s*VERSION_NUMBER: )[0-9]+/\1$VERSION_NUMBER/" $BITRISE_YML_FILE
sed -i -E "s/(\s*FLASK_VERSION_NUMBER: )[0-9]+/\1$VERSION_NUMBER/" $BITRISE_YML_FILE
echo "- $BITRISE_YML_FILE successfully updated"

# update ios/MetaMask.xcodeproj/project.pbxproj
echo "Updating iOS project settings..."
sed -i -E "s/(\s*CURRENT_PROJECT_VERSION = )[0-9]+/\1$VERSION_NUMBER/" $IOS_PROJECT_FILE
Expand All @@ -86,16 +73,10 @@ update_mobile_files () {
echo "All specified files updated with version number: $VERSION_NUMBER"
}

# get current numbers
CURRENT_VERSION_NUMBER=$(awk '/^\s+VERSION_NUMBER: /{print $2}' $BITRISE_YML_FILE);
CURRENT_FLASK_VERSION_NUMBER=$(awk '/^\s+FLASK_VERSION_NUMBER: /{print $2}' $BITRISE_YML_FILE);

# ensure version number of main variant and flask are aligned
if [[ "$CURRENT_VERSION_NUMBER" != "$CURRENT_FLASK_VERSION_NUMBER" ]]; then
echo "VERSION_NUMBER $CURRENT_VERSION_NUMBER and FLASK_VERSION_NUMBER $CURRENT_FLASK_VERSION_NUMBER should be the same"
log_and_exit "Check why they are different and fix it before proceeding"
fi

# Extract current build numbers from Android and iOS sources of truth.
# Use POSIX [[:space:]] for cross-platform awk compatibility (macOS BSD awk doesn't support \s).
CURRENT_ANDROID_VERSION_NUMBER=$(awk '/^[[:space:]]+versionCode /{print $2; exit}' $ANDROID_BUILD_GRADLE_FILE)
CURRENT_IOS_VERSION_NUMBER=$(awk -F'[[:space:]=;]+' '/CURRENT_PROJECT_VERSION/{print $3; exit}' $IOS_PROJECT_FILE)

if [[ -z $VERSION_NUMBER ]]; then
log_and_exit "VERSION_NUMBER not specified, aborting!"
Expand All @@ -107,12 +88,17 @@ if ! [[ $VERSION_NUMBER =~ $NAT ]] || [[ $VERSION_NUMBER =~ $SEMVER_REGEX ]]; th
fi

echo "VERSION_NUMBER is $VERSION_NUMBER."
echo "CURRENT_VERSION_NUMBER is $CURRENT_VERSION_NUMBER."
echo "CURRENT_ANDROID_VERSION_NUMBER is $CURRENT_ANDROID_VERSION_NUMBER."
echo "CURRENT_IOS_VERSION_NUMBER is $CURRENT_IOS_VERSION_NUMBER."

# ensure Android version number goes up
if [[ "$VERSION_NUMBER" -le "$CURRENT_ANDROID_VERSION_NUMBER" ]]; then
log_and_exit "Android version $VERSION_NUMBER is less than or equal to current: $CURRENT_ANDROID_VERSION_NUMBER"
fi

# ensure VERSION_NUMBER goes up
if [[ "$VERSION_NUMBER" -le "$CURRENT_VERSION_NUMBER" ]]; then
echo "version $VERSION_NUMBER is less than or equal to current: $CURRENT_VERSION_NUMBER"
exit 1
# ensure iOS version number goes up
if [[ "$VERSION_NUMBER" -le "$CURRENT_IOS_VERSION_NUMBER" ]]; then
log_and_exit "iOS version $VERSION_NUMBER is less than or equal to current: $CURRENT_IOS_VERSION_NUMBER"
fi

echo "VERSION_NUMBER is valid."
Expand Down
27 changes: 1 addition & 26 deletions .github/scripts/set-semvar-version.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

# Script to update semantic versioning across MetaMask platform files
# This script handles version updates for both mobile and extension platforms
# For mobile: Updates package.json, Android build.gradle, Bitrise config, and iOS project files
# For mobile: Updates package.json, Android build.gradle, and iOS project files
# For extension: Updates package.json only

set -e
Expand Down Expand Up @@ -36,7 +36,6 @@ SEMVER_REGEX="\
# File paths for version updates
PACKAGE_JSON_FILE=package.json
ANDROID_BUILD_GRADLE_FILE=android/app/build.gradle
BITRISE_YML_FILE=bitrise.yml
IOS_PROJECT_FILE=ios/MetaMask.xcodeproj/project.pbxproj

# Helper Functions
Expand Down Expand Up @@ -73,11 +72,6 @@ update_mobile_files () {
sed -i '' 's/\(\s*versionName \)".*"/\1"'"$SEMVER_VERSION"'"/' "$ANDROID_BUILD_GRADLE_FILE"
echo "- $ANDROID_BUILD_GRADLE_FILE successfully updated"

# Update version in Bitrise configuration
echo "Updating Bitrise configuration files..."
sed -i '' 's/\(\s*VERSION_NAME: \).*/\1'"$SEMVER_VERSION"'/' "$BITRISE_YML_FILE"
echo "- $BITRISE_YML_FILE successfully updated"

# Update iOS marketing version
echo "Updating iOS project settings..."
sed -i '' 's/\(\s*MARKETING_VERSION = \).*/\1'"$SEMVER_VERSION;"'/' "$IOS_PROJECT_FILE"
Expand All @@ -91,11 +85,6 @@ update_mobile_files () {
sed -i 's/\(\s*versionName \)".*"/\1"'"$SEMVER_VERSION"'"/' "$ANDROID_BUILD_GRADLE_FILE"
echo "- $ANDROID_BUILD_GRADLE_FILE updated"

# Update version in Bitrise configuration
echo "Updating Bitrise configuration files..."
sed -i 's/\(\s*VERSION_NAME: \).*/\1'"$SEMVER_VERSION"'/' "$BITRISE_YML_FILE"
echo "- $BITRISE_YML_FILE updated"

# update ios/MetaMask.xcodeproj/project.pbxproj
echo "Updating iOS project settings..."
sed -i 's/\(\s*MARKETING_VERSION = \).*/\1'"$SEMVER_VERSION;"'/' "$IOS_PROJECT_FILE"
Expand All @@ -104,7 +93,6 @@ update_mobile_files () {

# Print summary of updates
echo "- $ANDROID_BUILD_GRADLE_FILE updated"
echo "- $BITRISE_YML_FILE updated"
echo "- $IOS_PROJECT_FILE updated"

echo "-------------------"
Expand All @@ -125,19 +113,6 @@ if ! [[ $SEMVER_VERSION =~ $SEMVER_REGEX ]]; then
log_and_exit "$SEMVER_VERSION is invalid semver!"
fi

# Validate inputs for mobile platform
if [[ $PLATFORM == "mobile" ]]; then
# Get current version numbers from bitrise.yml
CURRENT_VERSION_NUMBER=$(awk '/^\s+VERSION_NUMBER: /{print $2}' $BITRISE_YML_FILE);
CURRENT_FLASK_VERSION_NUMBER=$(awk '/^\s+FLASK_VERSION_NUMBER: /{print $2}' $BITRISE_YML_FILE);

# Ensure version number of main variant and flask are aligned
if [[ "$CURRENT_VERSION_NUMBER" != "$CURRENT_FLASK_VERSION_NUMBER" ]]; then
echo "VERSION_NUMBER $CURRENT_VERSION_NUMBER and FLASK_VERSION_NUMBER $CURRENT_FLASK_VERSION_NUMBER should be the same"
log_and_exit "Check why they are different and fix it before proceeding"
fi
fi

echo "SEMVER_VERSION is valid."
echo -e "-------------------"
echo "Updating files:"
Expand Down
5 changes: 5 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,11 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [Unreleased]

### Changed

- Mobile release automation no longer reads from or writes to `bitrise.yml`; the build number (`versionCode` / `CURRENT_PROJECT_VERSION`) and semver (`versionName` / `MARKETING_VERSION`) are now sourced from `android/app/build.gradle` and `ios/MetaMask.xcodeproj/project.pbxproj` directly
- `set-semvar-version.sh`, `set-mobile-build-version.sh`, and `create-platform-release-pr.sh` updated accordingly, allowing consumers to remove `bitrise.yml`

## [1.15.0]

### Added
Expand Down