Skip to content

fix: marinade multisig dapp requests by preserving original message bytes - #156

Open
taran-a wants to merge 1 commit into
mainfrom
fix/marinade-multisig-messages
Open

fix: marinade multisig dapp requests by preserving original message bytes#156
taran-a wants to merge 1 commit into
mainfrom
fix/marinade-multisig-messages

Conversation

@taran-a

@taran-a taran-a commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

Explanation

Fixes multisig dapp transaction signing by preserving the original transaction payload for external dapp origins.

  • Decode dapp-origin signTransaction and signAndSendTransaction requests as transactions directly, whether the payload is a full serialized transaction or a bare compiled transaction message.
  • Append only the snap account's signature, preserving existing signatures, compiled messageBytes, account ordering, and instruction account indices.
  • Keep the existing MetaMask-origin signing flow unchanged.
  • Add coverage for codec decoding, signer byte preservation, and wallet origin handling.

References

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed
  • I've introduced breaking changes in this PR and have prepared draft pull requests for clients and consumer packages to resolve them

@taran-a
taran-a requested a review from a team as a code owner August 17, 2026 13:28
@taran-a
taran-a deployed to default-branch August 17, 2026 13:29 — with GitHub Actions Active
@taran-a
taran-a force-pushed the fix/marinade-multisig-messages branch from 15b6cf8 to cb532d8 Compare August 17, 2026 13:29
@taran-a
taran-a force-pushed the fix/marinade-multisig-messages branch from cb532d8 to 62574dd Compare August 18, 2026 08:38
@taran-a
taran-a force-pushed the fix/marinade-multisig-messages branch from 62574dd to c5b54f0 Compare August 18, 2026 09:14
@taran-a

taran-a commented Aug 18, 2026

Copy link
Copy Markdown
Contributor Author

@metamaskbot publish-preview

@github-actions

Copy link
Copy Markdown
Contributor

Preview builds have been published. Learn how to use preview builds in other projects.

Expand for full list of packages and versions.
@metamask-previews/bitcoin-wallet-snap@2.0.1-preview-c5b54f00
@metamask-previews/snap-networks-utils@1.0.0-preview-c5b54f00
@metamask-previews/solana-wallet-snap@6.0.0-preview-c5b54f00
@metamask-previews/tron-wallet-snap@3.1.0-preview-c5b54f00

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant