test(tron-wallet-snap): slim AssetsService tests to façade delegation - #162
Closed
ulissesferreira wants to merge 2 commits into
Conversation
Move Snap-path behavior coverage into SnapAssetsAdapter tests and keep AssetsService tests focused on adapter routing based on the migration flag. Co-authored-by: Ulisses Ferreira <ulisses@hey.com>
Use expect(await ...) instead of .resolves, and drop the unused no-explicit-any suppression from the old service test file. Co-authored-by: Ulisses Ferreira <ulisses@hey.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
AssetsServiceis a routing façade overSnapAssetsAdapterandCoreAssetsAdapter. Its tests still constructed real adapters and re-tested Snap fetch/save behavior (bandwidth, energy, staking, persistence) plus Core mapping/publish behavior.This PR:
AssetsService.test.tsintoSnapAssetsAdapter.test.tsAssetsServicetests to mock both adapters and assert only routing: Snap vs Core based on the Tron migration flag, plus the methods that always stay on SnapCoreAssetsAdapter.test.tsStacked on #145. Test-only; no changelog or breaking changes.
References
Checklist
Test plan
yarn workspace @metamask/tron-wallet-snap exec jest --no-coverage src/services/assets/AssetsService.test.ts src/services/assets/adapters/SnapAssetsAdapter.test.ts src/services/assets/adapters/CoreAssetsAdapter.test.ts— 85 passedyarn workspace @metamask/tron-wallet-snap run test— coverage thresholds met;AssetsService.tsis 100% statements/branches/functions/lines