Skip to content

fix(stellar-wallet-snap): satisfy price refresher typecheck - #165

Merged
ulissesferreira merged 2 commits into
mainfrom
ulissesferreira/fix-stellar-typecheck-8e1d
Aug 18, 2026
Merged

fix(stellar-wallet-snap): satisfy price refresher typecheck#165
ulissesferreira merged 2 commits into
mainfrom
ulissesferreira/fix-stellar-typecheck-8e1d

Conversation

@ulissesferreira

Copy link
Copy Markdown
Contributor

Explanation

ConfirmationPriceRefresher reduces prices into ContextWithPrices['tokenPrices'], whose type is a required Stellar asset-ID record. The empty reducer initializer was inferred as {}, causing the Stellar package typecheck to fail.

This restores the explicit accumulator type assertion so the reducer initializer matches the declared accumulator type.

References

  • Fixes the typecheck failure introduced while moving the Stellar snap into packages/.

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed
  • I've introduced breaking changes in this PR and have prepared draft pull requests for clients and consumer packages to resolve them
Open in Web Open in Cursor 

cursoragent and others added 2 commits August 18, 2026 16:03
Co-authored-by: Ulisses Ferreira <ulisses@hey.com>
Co-authored-by: Ulisses Ferreira <ulisses@hey.com>
@ulissesferreira
ulissesferreira marked this pull request as ready for review August 18, 2026 17:55
@ulissesferreira
ulissesferreira requested a review from a team as a code owner August 18, 2026 17:55
@ulissesferreira
ulissesferreira added this pull request to the merge queue Aug 18, 2026
@ulissesferreira
ulissesferreira deployed to default-branch August 18, 2026 17:55 — with GitHub Actions Active
Merged via the queue into main with commit 7fda22d Aug 18, 2026
56 checks passed
@ulissesferreira
ulissesferreira deleted the ulissesferreira/fix-stellar-typecheck-8e1d branch August 18, 2026 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants