Skip to content

chore: (1st commit) setup skeleton for batch sell review#29879

Draft
infiniteflower wants to merge 3 commits intoswaps-4437-multiswap-token-selectfrom
swaps-4439-batchSell-quotes
Draft

chore: (1st commit) setup skeleton for batch sell review#29879
infiniteflower wants to merge 3 commits intoswaps-4437-multiswap-token-selectfrom
swaps-4439-batchSell-quotes

Conversation

@infiniteflower
Copy link
Copy Markdown
Contributor

Description

Changelog

CHANGELOG entry:

Related issues

Fixes:

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

Performance checks (if applicable)

  • I've tested on Android
    • Ideally on a mid-range device; emulator is acceptable
  • I've tested with a power user scenario
    • Use these power-user SRPs to import wallets with many accounts and tokens
  • I've instrumented key operations with Sentry traces for production performance metrics

For performance guidelines and tooling, see the Performance Guide.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@metamaskbotv2 metamaskbotv2 Bot added the team-swaps-and-bridge Swaps and Bridge team label May 7, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 7, 2026

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@github-actions github-actions Bot added the size-M label May 7, 2026
@github-actions github-actions Bot added size-XL and removed size-M labels May 7, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 7, 2026

🔍 Smart E2E Test Selection

  • Selected E2E tags: SmokeSwap, SmokeConfirmations
  • Selected Performance tags: None (no tests recommended)
  • Risk Level: medium
  • AI Confidence: 88%
click to see 🤖 AI reasoning details

E2E Test Selection:
The PR introduces a new BatchSellReview screen and related components for the Bridge/Batch Sell flow. Key changes:

  1. New BatchSellReview screen (BatchSellReview.tsx, BatchSellReviewTokenRow.tsx, BatchSellPercentageSlider.tsx): A new review step in the batch sell flow showing selected tokens with percentage sliders and a destination stablecoin pill.

  2. Navigation flow change (BatchSellTokenSelect.tsx): The 'Next' action in BatchSellTokenSelect now navigates to the new BatchSellReview screen instead of QuoteSelectorView. This is a meaningful flow change in the batch sell path.

  3. New routes (Routes.ts, NavigationService/types.ts, routes.tsx): Added BatchSellReview route. The NavigationService/types.ts is marked critical but the change is minimal and scoped to adding one new route type — no risk to other navigation flows.

  4. Utility refactor (utils/index.ts, TokenSelectorItem.tsx): formatTokenBalance extracted from TokenSelectorItem to shared utils — same logic, no behavioral change.

  5. Token metadata (constants/tokens.ts): Added MUSD token metadata for the destination stablecoin.

  6. Localization (en.json): New strings for batch sell review UI.

Tag selection rationale:

  • SmokeSwap: All changes are within the Bridge/Swap feature area. The navigation flow change (BatchSellTokenSelect → BatchSellReview instead of QuoteSelectorView) directly affects the batch sell swap flow and needs validation.
  • SmokeConfirmations: Per SmokeSwap tag description, confirmations are part of the swap flow and should be selected alongside SmokeSwap.

No other tags are needed — changes are isolated to the Bridge/BatchSell feature with no impact on accounts, identity, network management, snaps, browser, or other features.

Performance Test Selection:
The new BatchSellPercentageSlider uses react-native-reanimated for animations, but this is a new feature screen in the batch sell flow — not a critical performance path like app launch, login, account list, or asset loading. No performance regression risk to existing measured flows.

View GitHub Actions results

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented May 7, 2026

Quality Gate Failed Quality Gate failed

Failed conditions
62.2% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant