Skip to content

fix(render): omit DepthStencilState on depthless pipelines for Vulkan compatibility #6713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Eccys wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(render): omit DepthStencilState on depthless pipelines for Vulkan compatibility #6713

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 1 addition & 12 deletions src/main/java/meteordevelopment/meteorclient/renderer/MeteorRenderPipelines.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,6 @@ public abstract class MeteorRenderPipelines {
.withVertexBinding(0, DefaultVertexFormat.POSITION_COLOR).withPrimitiveTopology(PrimitiveTopology.TRIANGLES)
.withVertexShader(MeteorClient.identifier("shaders/pos_color.vsh"))
.withFragmentShader(MeteorClient.identifier("shaders/pos_color.fsh"))
.withDepthStencilState(new DepthStencilState(CompareOp.ALWAYS_PASS, false))
.withColorTargetState(new ColorTargetState(BlendFunction.TRANSLUCENT))
.withCull(false)
.build()
Expand All @@ -59,7 +58,6 @@ public abstract class MeteorRenderPipelines {
.withVertexBinding(0, DefaultVertexFormat.POSITION_COLOR).withPrimitiveTopology(PrimitiveTopology.DEBUG_LINES)
.withVertexShader(MeteorClient.identifier("shaders/pos_color.vsh"))
.withFragmentShader(MeteorClient.identifier("shaders/pos_color.fsh"))
.withDepthStencilState(new DepthStencilState(CompareOp.ALWAYS_PASS, false))
.withColorTargetState(new ColorTargetState(BlendFunction.TRANSLUCENT))
.withCull(false)
.build()
Expand Down Expand Up @@ -96,7 +94,6 @@ public abstract class MeteorRenderPipelines {
.withVertexShader(MeteorClient.identifier("shaders/pos_color.vsh"))
.withFragmentShader(MeteorClient.identifier("shaders/pos_color.fsh"))
.withShaderDefine("UI")
.withDepthStencilState(new DepthStencilState(CompareOp.ALWAYS_PASS, false))
.withColorTargetState(new ColorTargetState(BlendFunction.TRANSLUCENT))
.withCull(true)
.build()
Expand All @@ -108,7 +105,6 @@ public abstract class MeteorRenderPipelines {
.withVertexShader(MeteorClient.identifier("shaders/pos_color.vsh"))
.withFragmentShader(MeteorClient.identifier("shaders/pos_color.fsh"))
.withShaderDefine("UI")
.withDepthStencilState(new DepthStencilState(CompareOp.ALWAYS_PASS, false))
.withColorTargetState(new ColorTargetState(BlendFunction.TRANSLUCENT))
.withCull(true)
.build()
Expand All @@ -122,7 +118,6 @@ public abstract class MeteorRenderPipelines {
.withBindGroupLayout(BindGroupLayout.builder()
.withUniform("u_Texture", UniformType.COMBINED_IMAGE_SAMPLER)
.build())
.withDepthStencilState(new DepthStencilState(CompareOp.ALWAYS_PASS, false))
.withColorTargetState(new ColorTargetState(BlendFunction.TRANSLUCENT))
.withCull(true)
.build()
Expand All @@ -136,7 +131,6 @@ public abstract class MeteorRenderPipelines {
.withBindGroupLayout(BindGroupLayout.builder()
.withUniform("u_Texture", UniformType.COMBINED_IMAGE_SAMPLER)
.build())
.withDepthStencilState(new DepthStencilState(CompareOp.ALWAYS_PASS, false))
.withColorTargetState(new ColorTargetState(BlendFunction.TRANSLUCENT))
.withCull(true)
.build()
Expand All @@ -154,7 +148,6 @@ public abstract class MeteorRenderPipelines {
.withUniform("PostData", UniformType.UNIFORM_BUFFER)
.withUniform("OutlineData", UniformType.UNIFORM_BUFFER)
.build())
.withDepthStencilState(new DepthStencilState(CompareOp.ALWAYS_PASS, false))
.withColorTargetState(new ColorTargetState(BlendFunction.TRANSLUCENT))
.withCull(false)
.build()
Expand All @@ -171,7 +164,6 @@ public abstract class MeteorRenderPipelines {
.withUniform("PostData", UniformType.UNIFORM_BUFFER)
.withUniform("ImageData", UniformType.UNIFORM_BUFFER)
.build())
.withDepthStencilState(new DepthStencilState(CompareOp.ALWAYS_PASS, false))
.withColorTargetState(new ColorTargetState(BlendFunction.TRANSLUCENT))
.withCull(false)
.build()
Expand All @@ -188,7 +180,6 @@ public abstract class MeteorRenderPipelines {
.withUniform("u_Texture", UniformType.COMBINED_IMAGE_SAMPLER)
.withUniform("BlurData", UniformType.UNIFORM_BUFFER)
.build())
.withDepthStencilState(new DepthStencilState(CompareOp.ALWAYS_PASS, false))
.withColorTargetState(new ColorTargetState(BlendFunction.TRANSLUCENT))
.withCull(false)
.build()
Expand All @@ -203,19 +194,17 @@ public abstract class MeteorRenderPipelines {
.withUniform("u_Texture", UniformType.COMBINED_IMAGE_SAMPLER)
.withUniform("BlurData", UniformType.UNIFORM_BUFFER)
.build())
.withDepthStencilState(new DepthStencilState(CompareOp.ALWAYS_PASS, false))
.withColorTargetState(new ColorTargetState(BlendFunction.TRANSLUCENT))
.withCull(false)
.build()
);

public static final RenderPipeline BLUR_PASSTHROUGH = add(new ExtendedRenderPipelineBuilder(MESH_UNIFORMS)
.withLocation(MeteorClient.identifier("pipeline/blur/up"))
.withLocation(MeteorClient.identifier("pipeline/blur/passthrough"))
.withVertexBinding(0, MeteorVertexFormats.POS2).withPrimitiveTopology(PrimitiveTopology.TRIANGLES)
.withVertexShader(MeteorClient.identifier("shaders/passthrough.vsh"))
.withFragmentShader(MeteorClient.identifier("shaders/passthrough.fsh"))
.withBindGroupLayout(BindGroupLayout.builder().withUniform("u_Texture", UniformType.COMBINED_IMAGE_SAMPLER).build())
.withDepthStencilState(new DepthStencilState(CompareOp.ALWAYS_PASS, false))
.withColorTargetState(new ColorTargetState(BlendFunction.TRANSLUCENT))
.withCull(false)
.build()
Expand Down
Loading