Repository navigation
libdiff: update truncation test for EIO return - #572
Merged
Merged
Conversation
Commit 19f69c3 removed DIFF_ATOMIZER_FILE_TRUNCATED and made the atomizer return EIO on truncation, but the ATF test still referenced the removed flag and expected a 0 return, breaking buildworld. Expect EIO from diff_atomize_file() and drop the flag check. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Reviewer's guide (collapsed on small PRs)Reviewer's GuideUpdates the libdiff truncation test for the atomizer’s EIO return after file truncation, removes the obsolete flag assertion, and preserves length-based detection checks. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Commit 19f69c3 removed
DIFF_ATOMIZER_FILE_TRUNCATEDand changed the libdiff atomizer to returnEIOwhen a file is truncated.lib/libdiff/tests/libdiff_test.cstill referenced the removed flag and expected a0return, somake buildworldfails when building the tests.This change makes the test expect
EIOfromdiff_atomize_file()and removes the flag check. The length checks stay, so the test still confirms that truncation is detected at the right place. Nothing else in the tree uses the removed flag.Testing
-Wall -Werroragainst the ATF headers incontrib/atf.🤖 Generated with Claude Code
Summary by Sourcery
Bug Fixes: