Repository navigation
Update Lootable Bodies for Minecraft 1.12.2 - #31
Open
SkyBlade1978 wants to merge 8 commits into
Open
SkyBlade1978 wants to merge 8 commits into
SkyBlade1978 wants to merge 8 commits into
Conversation
Bring the maintained recovery fixes and Config screen to 1.12.2. Preserve older corpses and their inventories when upgrading, including chunks visited later.
Keep the copied journal before injecting deliberately invalid data, so worlds already saved by the maintained versions run through the same checks.
Avoid the slow Azure package mirror when installing the display and audio dependencies on hosted runners. Keep the same packages and test limits.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brings the maintained recovery fixes and the Mods-list Config screen to Minecraft 1.12.2. Existing corpse identities and settings stay the same, including the buoyancy and void-platform defaults.
Older 1.10, 1.11 and 1.12 corpses and their items are protected during upgrades, including chunks visited later. Items from missing mods are kept for recovery when those mods return.
Manual testing passed. Local checks include 54 unit tests, the inventory regressions, 16 upgrade cases with repeated saves and delayed chunks, and graphical client/server and two-player checks. Release files are reproducible and audited.