Repository navigation
AGENTS.md: cover package updates and changes to the checks or the contract docs - #85
Merged
Merged
Conversation
…contract docs AGENTS.md described only adding or updating a package, and the update path was one sentence. Two branches agents already take were missing: - Updating a package: keep the plugin ID, raise version, and call out a newly declared field that raises the minimum client version, since it drops older clients. - Changing the checks or the docs: minimum versions come from the first released client, not a preview build (#59 recorded 3.1.4 from a preview; the released 3.1.4 rejects the field, fixed in #81); contract, rule, test, and docs change together; the checker stays dependency-free; a new error must keep existing packages at zero errors because CI validates all of them; and contract changes go in their own PR. Assisted-by: Claude Opus 5.5 (OpenCode)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AGENTS.md only covered adding a package; updating a package got a single sentence. This adds two branches agents already take here:
version, and call out a newly declared field that raises the minimum client version, since it drops older clients.session.read; Sync the package checks and docs with the MiniMax Code 3.1.5 Mini App contract #81 fixed it;Verified againstlines are updated;The opening line now points to the new section.
Left out on purpose:
lsshows;npm run checkenforces anddocs/package-contract.mddocuments.Verification
scripts/lib/rules/*.mjshas atest/<rule>.test.mjs;docs/*.mdcarry aVerified againstline;package.jsonhas no dependencies.npm run check: 87 tests pass, including the wording test, which scans AGENTS.md.Need help on this PR? Tag
@codesmith-botwith what you need.